Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce python dependencies #25443

Closed
wants to merge 1 commit into from
Closed

Reduce python dependencies #25443

wants to merge 1 commit into from

Conversation

grosjo
Copy link

@grosjo grosjo commented Nov 25, 2024

Maintainer: grosjo
Compile tested: ath79, 24.10
Run tested: ath79, 24.10

Description:
Purpose is to reduce the number of libraries and related size that are useless for some modules

@grosjo grosjo force-pushed the master branch 3 times, most recently from 4feec58 to 3c2df63 Compare November 25, 2024 13:15
@grosjo grosjo changed the title Add TinyTuya Add Python package : TinyTuya Nov 25, 2024
@grosjo grosjo force-pushed the master branch 8 times, most recently from 7b32f88 to c7263cd Compare November 26, 2024 06:05
@grosjo grosjo changed the title Add Python package : TinyTuya Reduce python dependencies Nov 26, 2024
@grosjo grosjo force-pushed the master branch 3 times, most recently from c19d468 to 86d6403 Compare December 6, 2024 10:18
@grosjo grosjo force-pushed the master branch 2 times, most recently from 881a068 to 0e5b82d Compare December 16, 2024 05:06
@grosjo
Copy link
Author

grosjo commented Dec 25, 2024

@commodo and @vidplace7 : How to push this in master ?
Thank you so much

@commodo
Copy link
Contributor

commodo commented Dec 25, 2024

PKG_RELEASE needs to be incremented in both Makefile

@commodo
Copy link
Contributor

commodo commented Dec 25, 2024

Test formalities need to be addressed

@jefferyto
Copy link
Member

  • python3-urllib depends on python3-email (python3: Circular dependency between python3-email and python3-urllib #12942), until that issue is resolved that's why python-cryptography includes the dependency on python3-email

  • If you run make package/python-urllib3/configure PY3=stdlib V=s you will see the package depends on:

    • python3-asyncio
    • python3-ctypes
    • python3-email
    • python3-logging
    • python3-openssl
    • python3-urllib

    asyncio appears to be only used in the dummyserver, but the other packages appear to be real dependencies. That's why python-urllib3 depends on python3 (instead of the 5 separate packages)

Maintainer: grosjo

This line should mention the package maintainers (@BKPepe and myself), not the author of the PR.

@BKPepe
Copy link
Member

BKPepe commented Dec 25, 2024

I will add more dependencies in separate PR for urllib3, thanks for checking, @jefferyto.

@BKPepe BKPepe closed this Dec 25, 2024
@grosjo
Copy link
Author

grosjo commented Dec 26, 2024

Instead of arguing on urllib3 having a circular dep on email (which is wrong, as I can compile properly without any issue using my PR), maybe better test/fix it instead ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants