Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SciUnit test to reproduce additional muscle patch clamp data in the muscle model #64

Open
slarson opened this issue Feb 19, 2017 · 7 comments
Assignees

Comments

@slarson
Copy link
Member

slarson commented Feb 19, 2017

Currently, a notebook that executes one of the muscle models being run out of c302 is here

We want to fit this to existing data.

Figures are here

Ideally we'd be running both the model and the comparison with data inside SciUnit.

@slarson
Copy link
Member Author

slarson commented Jul 21, 2017

@rgerkin Can we set up a time in a couple weeks to discuss this?

@rgerkin
Copy link
Member

rgerkin commented Jul 25, 2017

@slarson Yes, most mid-day times will work for me.

@rgerkin
Copy link
Member

rgerkin commented Aug 12, 2017

@slarson
In progress.

@rgerkin
Copy link
Member

rgerkin commented Oct 4, 2017

Currently neuronunit is giving each processor its own copy of the root NML/LEMS file so that it may rewrite it as needed for certain tasks. This is important when simulations are done via jNeuroML since jNeuroML takes a path to a file which then represents the structure of the model which cannot be changed in memory.

c302 NML files contain local include directives to other c302 NML files in same directory. In order to copy the root c302 NML file elsewhere, I need jNeuroML to know to look in a list of include directories that includes the original root c302 NML file directory, so that it can find these include files. Padraig implemented this in NeuroML/jNeuroML@a714ffa.

However, in order to use this development branch, I have to get it to compile, which is currently failing as described in NeuroML/jNeuroML#52.

When that issue is resolved I can continue making progress on this one.

@rgerkin
Copy link
Member

rgerkin commented Oct 6, 2017

The above issues are now solved and I have a prototype shown here. This just demonstrates wrapping the model with a SciUnit Model class and getting the c302 simulation to run. The next step is to actually do the testing, but that should be the easy part.

@rgerkin
Copy link
Member

rgerkin commented Jan 23, 2018

@slarson Is the data in the figure in the "Figures are here" link in your first comment on this issue available in digitized form anywhere? Panel C is easy enough to do by hand, but A, D, and E probably require the raw values or a digitization of the figure in order to test. Does muscle_model have its own version of channelworm-django?

@rgerkin
Copy link
Member

rgerkin commented Jan 25, 2018

@slarson Here I have the muscle model being tested (against a suite of two tests) in SciUnit. I can add more tests from the table in panel C of the figure later. Showing an overlaid comparison probably requires getting a digitized figure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants