-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write SciUnit validation tests for muscle_model #38
Comments
Can we re-open specific issues with the two tests that you described above? Just so that the issue names detail precisely what needs to be done. |
I've started this here. The first part looks more or less like what we have in ChannelWorm, except instead of loading it from the database I am loading it from the .csv files in the BoyleCohen2008/data directory. The same scale issue is apparent as in the corresponding ChannelWorm notebook. The second part looks way off, and I'm not sure why. Unless I'm doing something wrong, the K channel model has rectification properties that it shouldn't have (in addition to the scale issue, which is more trivial). Possible things I could be doing wrong: simulating the wrong model somehow, computing currents at the wrong time point, ? The third part is the beginning of a whole cell test, including voltage and calcium time courses, but I don't know what data to use to write a test for this. |
@VahidGh "Yes" it is experimental data or "Yes" it is simulated data? Thanks for the link. |
@rgerkin, The link in your comment, is experimental data. And the link addressed by me is simulated data. |
The data here: https://github.com/openworm/muscle_model/tree/master/BoyleCohen2008/data seems like experimental data, but no info/notes associated with it. I'd suggest first making sure their data matches the output of their matlab scripts before looking at the match to nml2 version. You could probably work with Rayner's python version too. Note, the ca trace should work for the nml2 version (see openworm/ChannelWorm#96 (comment)), but note the K iv curve is for k_fast+k_slow, and there is no current way to get the total K current from the nml2 version (unless making 2 ivCurve analysis scripts and adding them) |
Related issue: #64 |
Revisiting this today in the context of the scientific roadmap. Here are the steps that are required to close this off:
|
We need to sort out the topic of where the output objects from the notebooks will go once travis generates them. Previous they had been going into s3 but this may not be the best strategy going forward. (cc @rgerkin ) |
This issue can be closed when two tests of connectivity are implemented and incorporated into the test suite using SciUnit
The text was updated successfully, but these errors were encountered: