[groups] Added default "operator" and "user manager" groups. #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R9295
force-pushed
the
master
branch
3 times, most recently
from
b227ae3 to
53f822b
Compare
This was referenced Oct 25, 2018
nemesifier
requested changes
Oct 25, 2018
| operator = group.objects.filter(name='operator') | ||
| if operator.count() == 0: | ||
| operator = group.objects.create(name='operator') | ||
| operator.permissions.set([]) |
There was a problem hiding this comment.
this line is not needed now, right?
| user_manager.permissions.set([ | ||
| Permission.objects.get(codename='add_user').pk, | ||
| Permission.objects.get(codename='change_user').pk, | ||
| Permission.objects.get(codename='view_user').pk, |
There was a problem hiding this comment.
this permission is available only from django 2.1 onwards (finally!). In order to support older versions of django the simples thing you can do in this case is to build the list of permissions (except the view one) before the set call, then append the view_user permission within a try, except DoesNotExist: block.
|
PS: also rebase on the current master when you can |
Implements and closes openwisp#31
pandafy
pushed a commit
that referenced
this pull request
Jan 12, 2021
Removed the logics which were duplicated in the others modules and redefined it here to enable reusability and ease debugging. Fixes #40
pandafy
pushed a commit
that referenced
this pull request
Jan 12, 2021
[admin] Removed logic duplicates #40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements and closes #31