[fix] Assigned a callable to model choices attribute to deal with the latest NOTIFICATION_CHOICES #269
Conversation
… latest NOTIFICATION_CHOICES Created get_notification_choices() to dynamically update the choices attribute of models with the latest NOTIFICATION_CHOICES. this fixes issues in tests where the updates that applied on NOTIFICATION_CHOICES don't reflect on the choices attributes in the models.
There was a problem hiding this comment.
@mohamedAbdelaleem these changes do not seem very critical to me, we didn't have any test failure before.
What Django and Python versions are you using?
The build is faling for QA checks, please review and read instructions in the build output on how to fix those.
There was a problem hiding this comment.
After running the tests locally I encountered some errors. One caused by a typo here. Additionally, certain test cases are updating the NOTIFICATION_CHOICES, but these updates are not reflected in the choices attribute of the affected models.
Can you please explain the steps you're following to replicate this test failure please? And point out what tests you are referring to?
I am using Python 3.12 and that is the reason. After downgrading to Python 3.9, I don't have any test failures. |
After running the tests locally I encountered some errors. One caused by a typo here. Additionally, certain test cases are updating the NOTIFICATION_CHOICES, but these updates are not reflected in the choices attribute of the affected models.