chore: relative url for notification links

[Dhanus3133]

Fixes: #249

[nemesifier]

Thank you @Dhanus3133, it looks good.

Here's a few things to improve, see below.

The REST API is returning relative URLs as shown in the following screenshot:

That's unintended, we only want this new behavior in the admin widget, the API may be hosted on a different domain and hence must return the full URL.

Please also add a new unit test which tests the new methods that allow returning the relative URLs.

Watch out also from build failures because of failed QA checks, please read the build output to find out how to run qa checks locally and how to fix common formatting and commit message format issues.

[Dhanus3133]

Updated with just the required notification widget changes, although the QA checks for the CSS files are failing for some reason.

[nemesifier]

Works as expected now, thanks!
Take a look at the comments below for some minor code improvements.

If you can add a selenium browser test for this it would be great, let me know!

[Dhanus3133]

@nemesifier, I tried adding Selenium tests, but when the notification tab is clicked, it just loads. When I look into the console, it says it cannot find WS and returns 404 in the network.

Could you help me here? Thanks.

[nemesifier]

it just loads

Did you mean "it doesn't load"?

[Dhanus3133]

Did you mean "it doesn't load"?

I meant the WebSocket connection is not found, so in the front end, it just waits, causing the spinning UI.

recording.mp4

[nemesifier]

The base test class StaticLiveServerTestCase does not support websockets.

Here's a rough outline of how we might structure these tests:

from django.contrib.staticfiles.testing import StaticLiveServerTestCase
from channels.testing import ChannelsLiveServerTestCase

class SeleniumTestNotifications(StaticLiveServerTestCase, ChannelsLiveServerTestCase):
    # ... etc ...

Please consults these links for more information:

• ChannelsLiveServerTestCase docs
• StaticLiveServerTestCase docs

[nemesifier]

@Dhanus3133 I missed the latest updates on this, will review asap.

[nemesifier]

Great work @Dhanus3133, I left some comments below, I am doing some quick tests locally to verify some of my comments.

[nemesifier]

@Dhanus3133 I pushed some improvements, feel free to review the changes. Once the build passes I will merge. 👍