Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add smarter configuration merge mechanism #19

Closed
nemesifier opened this issue Apr 20, 2016 · 2 comments
Closed

Add smarter configuration merge mechanism #19

nemesifier opened this issue Apr 20, 2016 · 2 comments
Assignees
Milestone

Comments

@nemesifier
Copy link
Member

nemesifier commented Apr 20, 2016

We need a smarter configuration merging mechanism that does the following:

  • does not cause issue store_unmanaged duplicates unnamed configurations & lists #17
  • separates the remote configuration from the local one
  • merges the remote configuration on the local one by default (with the optional possibility to overwrite instead of merging)
  • removes configuration that were added but then later removed
@nemesifier nemesifier self-assigned this Apr 20, 2016
@nemesifier nemesifier added this to the 0.4 milestone Apr 20, 2016
@sheerun
Copy link

sheerun commented May 19, 2016

I think overwirte instead of merging is better default. Plus make merging configurable opt-in

@nemesifier
Copy link
Member Author

@sheerun there are several challenges in this task, if you overwrite by default you will have to keep a lot of boilerplate configuration in the controller, and implementing merge is not easy because of anonymous UCI configuration sections that cannot be merged, trying to merge two anonymous configsurations will result in two duplicated configurations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants