feat: add [email protected] support #671
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
=======================================
Coverage 97.26% 97.26%
=======================================
Files 1 1
Lines 73 73
Branches 16 16
=======================================
Hits 71 71
Misses 2 2
Continue to review full report at Codecov.
|
alias-mac
force-pushed
the
mongodb-4-compatible
branch
2 times, most recently
from
3d12a07
to
829489d
Compare
alias-mac
changed the title
|
Need to wait for mongodb/node-mongodb-native#3102 to land before testing and using the latest version by default. |
alias-mac
commented
Jan 17, 2022
package.json
Outdated
| @@ -51,7 +50,7 @@ | |||
| "husky": "^7.0.4", | |||
| "jest": "^27.4.7", | |||
| "lint-staged": "^12.1.7", | |||
| "mongodb": "^3.6.7", | |||
| "mongodb": "~4.1.0", | |||
There was a problem hiding this comment.
Will move this to ^4.0.0 once mongodb/node-mongodb-native#3102 is published.
alias-mac
force-pushed
the
mongodb-4-compatible
branch
3 times, most recently
from
6278973
to
f50e7e1
Compare
BREAKING CHANGE: it is hard to support both versions (3.x and 4.x) of native driver on the same branch because 4.x has native types definitions and they diverge from the ones provided by @types/mongodb. This means that this version might still be compatible with previous versions of mongodb native driver (3.6.x and 3.7.x), but we aren't testing them due to typescript mismatch. Please open an issue and we will try to support your use case.
alias-mac
force-pushed
the
mongodb-4-compatible
branch
from
f50e7e1
to
b1675be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: it is hard to support both versions (3.x and 4.x) of
native driver on the same branch because 4.x has native types
definitions and they diverge from the ones provided by @types/mongodb.
This means that this version might still be compatible with previous
versions of mongodb native driver (3.6.x and 3.7.x), but we aren't
testing them due to typescript mismatch.
Please open an issue and we will try to support your use case.