-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ci publish action #89
Conversation
Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
=======================================
Coverage 92.07% 92.07%
=======================================
Files 21 21
Lines 1514 1514
Branches 229 229
=======================================
Hits 1394 1394
Misses 113 113
Partials 7 7 ☔ View full report in Codecov by Sentry. |
@cre8 How about managing with main, release, unstable? |
I thought changing the default branch would be tricky, so I thought I'd just make the default branch "main". |
Let's merge it after default branch is changed. |
Keeping this PR open until #91 is done to avoid conflicts |
Signed-off-by: Mirko Mollik <[email protected]>
@lukasjhan I added the settings file that should set the default branch to next. we are also able to define other rules in this file so #91 can be closed with this PR |
Signed-off-by: Mirko Mollik <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. Can we merge it? @cre8
@lukasjhan I think so |
@lukasjhan I had to open another PR to add the |
Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
Signed-off-by: Mirko Mollik <[email protected]> Co-authored-by: Mirko Mollik <[email protected]> Signed-off-by: Mirko Mollik <[email protected]>
closes: #44
Updates the used variables so the action runs.
@lukasjhan
we need to define what is the "primary" branch. Veramo has this logic:
This approach allows to have a tested version approach (because when we saw some bug on the next release, we can overwrite it in an easy way). On the other hand it's still the classic approach for the user because he can use latest or no version number during the installation to make sure he gets the latest released version.