-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Anoncreds Offer Attachment Type #2124
fix: Anoncreds Offer Attachment Type #2124
Conversation
|
Signed-off-by: George Mulhearn <[email protected]>
49bb970
to
02b9e1d
Compare
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
@@ -567,7 +567,7 @@ export class AnonCredsCredentialFormatService implements CredentialFormatService | |||
// if the proposal has an attachment Id use that, otherwise the generated id of the formats object | |||
const format = new CredentialFormatSpec({ | |||
attachmentId: attachmentId, | |||
format: ANONCREDS_CREDENTIAL, | |||
format: ANONCREDS_CREDENTIAL_OFFER, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wanted to make sure this won't break previous versions, but we basically allow any of the identifiers for all messags, which is a bit weird but in this case helps a lot (but probably also why we didn't dettect this for so long)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yep makes sense. i'm not sure if you guys had been interop testing with acapy, but they also have some minor issues with the attachment naming which i imagine would cause interop issues (see openwallet-foundation/acapy#3374). Hopefully after that we can have some good interop. this is specifically coming up as i've been testing out cheqd anoncreds (being introduced to acapy soon).
49abaf6
into
openwallet-foundation:main
issue-credential-v2 anoncreds didcomm attachments are sending with
anoncreds/[email protected]
format type rather thananoncreds/[email protected]
spec:
https://github.com/hyperledger/aries-rfcs/blob/main/features/0771-anoncreds-attachments/README.md#credential-offer-format