Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Anoncreds Offer Attachment Type #2124

Merged

Conversation

gmulhearn
Copy link
Contributor

issue-credential-v2 anoncreds didcomm attachments are sending with anoncreds/[email protected] format type rather than anoncreds/[email protected]

spec:
https://github.com/hyperledger/aries-rfcs/blob/main/features/0771-anoncreds-attachments/README.md#credential-offer-format

Copy link

changeset-bot bot commented Dec 5, 2024

⚠️ No Changeset found

Latest commit: 58b26e4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: George Mulhearn <[email protected]>
@gmulhearn gmulhearn force-pushed the gm/ac-attachment-type-fix branch from 49bb970 to 02b9e1d Compare December 5, 2024 05:07
@gmulhearn gmulhearn changed the title Anoncreds Offer Attachment Type fix: Anoncreds Offer Attachment Type Dec 5, 2024
Signed-off-by: George Mulhearn <[email protected]>
Signed-off-by: George Mulhearn <[email protected]>
@@ -567,7 +567,7 @@ export class AnonCredsCredentialFormatService implements CredentialFormatService
// if the proposal has an attachment Id use that, otherwise the generated id of the formats object
const format = new CredentialFormatSpec({
attachmentId: attachmentId,
format: ANONCREDS_CREDENTIAL,
format: ANONCREDS_CREDENTIAL_OFFER,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to make sure this won't break previous versions, but we basically allow any of the identifiers for all messags, which is a bit weird but in this case helps a lot (but probably also why we didn't dettect this for so long)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep makes sense. i'm not sure if you guys had been interop testing with acapy, but they also have some minor issues with the attachment naming which i imagine would cause interop issues (see openwallet-foundation/acapy#3374). Hopefully after that we can have some good interop. this is specifically coming up as i've been testing out cheqd anoncreds (being introduced to acapy soon).

@TimoGlastra TimoGlastra merged commit 49abaf6 into openwallet-foundation:main Dec 5, 2024
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants