Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore!: update dependencies #1388

Merged

Conversation

TimoGlastra
Copy link
Contributor

@TimoGlastra TimoGlastra commented Mar 18, 2023

Fixes #1213 and Fixes #1267

Also removed support for node 17 as it's reached EOL (not a LTS release), and it's not compatible with all pacakges. In addition I've removed support for node 14 as not all packages support it, and it'll reach EOL this month. I think it's fine to remove it for 0.4.0, and focus on Node 16 and 18

BREAKING CHANGE:
Node.JS 14 and 17 have been dropped. Node.JS 17 has reached it's end of life, and Node.JS 14 will do so within a month. Support for Node.JS 20 will be added once it's released.

Signed-off-by: Timo Glastra <[email protected]>
@TimoGlastra TimoGlastra requested a review from a team as a code owner March 18, 2023 22:05
@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2023

Codecov Report

Merging #1388 (8e8b1da) into main (47636b4) will increase coverage by 12.00%.
The diff coverage is 87.50%.

@@             Coverage Diff             @@
##             main    #1388       +/-   ##
===========================================
+ Coverage   73.60%   85.60%   +12.00%     
===========================================
  Files         695      864      +169     
  Lines       17144    20474     +3330     
  Branches     2759     3308      +549     
===========================================
+ Hits        12619    17527     +4908     
+ Misses       4520     2939     -1581     
- Partials        5        8        +3     
Impacted Files Coverage Δ
packages/core/tests/logger.ts 86.04% <87.50%> (ø)

... and 363 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@genaris genaris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few details, but good to see these updates. Dropping support for Node 14 and 17 will also make CI easier to pass 😆 .

Do you think we should start adding Node 19 to the suite?

packages/anoncreds/package.json Outdated Show resolved Hide resolved
demo/package.json Outdated Show resolved Hide resolved
@TimoGlastra TimoGlastra enabled auto-merge March 23, 2023 17:06
auto-merge was automatically disabled March 27, 2023 09:28

Merge queue setting changed

@TimoGlastra TimoGlastra added this to the 0.4.0 milestone Mar 30, 2023
@TimoGlastra TimoGlastra merged commit 9558256 into openwallet-foundation:main Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update jest to latest version Update packages
3 participants