fix: double pin screen

[wadeking98]

Summary of Changes

• Added fix to stop PIN screen from appearing twice.
• Moved async storage calls to dependency injection called once in rootstack
• Promisified async storage calls to run in parallel, seeping up app startup

fixSplashStartup.mov

Related Issues

N/A

Pull Request Checklist

Tick all boxes below to demonstrate that you have completed the respective task. If the item does not apply to your this PR check it anyway to make it apparent that there's nothing to do.

• All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this);
• Updated LICENSE-3RD-PARTY.md for any added dependencies or vendored components;
• Updated documentation as needed for changed code and new or modified features;
• Added sufficient tests so that overall code coverage is not reduced.

If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!

Pro Tip 🤓

• Read our contribution guide at least once; it will save you a few review cycles!
• Your PR will likely not be reviewed until all the above boxes are checked and all automated tests have passed.

PR template adapted from the Python attrs project.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 10.25641% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 62.02%. Comparing base (0a4903c) to head (a1fc59d).

Files	Patch %	Lines
packages/legacy/core/App/container-impl.ts	4.76%	20 Missing ⚠️
packages/legacy/core/App/screens/Splash.tsx	33.33%	6 Missing ⚠️
...ackages/legacy/core/App/contexts/reducers/store.ts	0.00%	5 Missing ⚠️
packages/legacy/core/App/navigators/RootStack.tsx	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1121      +/-   ##
==========================================
- Coverage   62.09%   62.02%   -0.08%     
==========================================
  Files         178      178              
  Lines        5733     5738       +5     
  Branches     1655     1654       -1     
==========================================
- Hits         3560     3559       -1     
- Misses       2150     2156       +6     
  Partials       23       23              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[wadeking98]

I had to use the (val) => (thing = val) pattern here because I needed to mutate the thing variable inside the generic function but I couldn't use useRef or useState because react would complain about hooks being used in the wrong place. There's probably a better way to do this, feel free to mention it if you think of a better alternative

[bryce-mcmath]

Just one small thing, otherwise I think this is a great change