Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/universal resolver #3354

Merged
merged 3 commits into from
Nov 25, 2024

Conversation

jamshale
Copy link
Contributor

The https://dev.uniresolver.io/1.0/properties endpoint which is the default url for the universal resolver changed recently and acapy failed to handle the response.

The patterns are now the keys of the json payload.

swcurran
swcurran previously approved these changes Nov 25, 2024
@jamshale jamshale marked this pull request as ready for review November 25, 2024 17:22
@jamshale
Copy link
Contributor Author

I need to figure out how to turn off the https check in sonarcloud. Doesn't really apply to this project very often.

Looks like the interop tests are working now...

@jamshale jamshale linked an issue Nov 25, 2024 that may be closed by this pull request
@jamshale
Copy link
Contributor Author

I just realized that if a deployment is using a different universal resolver that hasn't changed then this would probably break it.

I'm going to change it to have compatibility support.

@jamshale jamshale marked this pull request as draft November 25, 2024 18:02
@jamshale jamshale marked this pull request as ready for review November 25, 2024 18:34
Copy link

sonarcloud bot commented Nov 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots

See analysis details on SonarQube Cloud

@jamshale jamshale merged commit 799cd64 into openwallet-foundation:main Nov 25, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACA-Py failing to start, gives KeyError: 'pattern'
2 participants