🎨 Refactor the logging module monolith #3319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
5 "security hotspots" identified by sonarcloud -- they seem to be safe to ignore |
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
Signed-off-by: ff137 <[email protected]>
ff137
force-pushed
the
modularise-logging-monolith
branch
from
082f71c to
5c27b13
Compare
|
|
This is ready? Looking good to me 👍 |
|
@jamshale I'm happy with it! Tested it and everything looks the same 👍 |
jamshale
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing
acapy_agent/config/logging.pymodule is a monolith, containing multiple logging-related functionalities.This PR breaks down the module into smaller, more focused components under
config/logging/to improve maintainability and testability. No functional changes are introduced; this is purely a structural reorganization. Everything in the previouslogging.pymodule has been copied directly and split up into bespoke modules.(Note: This is a pre-cursor PR to introducing loguru as an optional log provider. So, this is some initial refactoring to help streamline that contribution.) (edit: maybe no need for loguru, but the refactoring helps for general maintainability)