Correct the names of shared region functions. #5585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type is region_t but the functions are init/alloc/free_region(). Closes openwall#5571 but copies of the functions still remain in yescrypt directory, not sure if they are identical or not.
solardiz
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Looks good to me.
The copies under yescrypt are all static, so should not clash with these at link time, and not at compile time either because yescrypt files do not inlcude our memory.*, and our formats that use yescrypt only include yescrypt.h and not any of the .c files from there.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type is region_t but the functions are init/alloc/free_region().
Closes #5571 but copies of the functions still remain in yescrypt directory, not sure if they are identical or not.