Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing licenses #4170

Merged
merged 5 commits into from
Jan 7, 2025
Merged

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Jan 2, 2025

Summary

ruff configuration looks hacky now, because we have an outdated ruff.
To apply new one, refactoring of the configuration is required.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2025 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests BUILD labels Jan 2, 2025
Copy link
Contributor

@ashwinvaidya17 ashwinvaidya17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@samet-akcay
Copy link
Contributor

Thanks @sovrasov! Now that you added this, maybe we could remove the license section from the pull request template?
https://github.com/openvinotoolkit/training_extensions/blob/develop/.github/pull_request_template.md

@sovrasov
Copy link
Contributor Author

sovrasov commented Jan 2, 2025

Thanks @sovrasov! Now that you added this, maybe we could remove the license section from the pull request template? https://github.com/openvinotoolkit/training_extensions/blob/develop/.github/pull_request_template.md

Why should we remove it? The linter doesn't explain how the license should look like, it just checks if the proper header was added.

@sovrasov sovrasov merged commit 8296a43 into openvinotoolkit:develop Jan 7, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants