-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor exporter for anomaly task and fix a bug with exportable code #3672
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## releases/2.1.0 #3672 +/- ##
==================================================
+ Coverage 80.82% 80.84% +0.01%
==================================================
Files 250 251 +1
Lines 25988 25988
==================================================
+ Hits 21005 21009 +4
+ Misses 4983 4979 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ashwinvaidya17 Can you take a look at this PR? and I have one question, why didn't that issue show up in the integration test? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work. I left some comments. Please take a look.
@kprokofi The integration test locally throws 'FAILED' due to that issue, but it seems to be passing in CI. We'll need to do a general check to make sure our export-related integration tests are working locally. |
* [hotfix] Update for fix workflow issues (#3668) * Update README & CODEOWNERS (#3659) * Update Engine's docstring & CLI --help outputs (#3658) Update Engine's CLI docstring & HelpFormatter * Fix unit test for semantic segmentation to run it without mmseg (#3670) fix test to run wo mm * Enable ruff & ruff-format into otx/algo/classification/backbones (#3667) * Enable ruff in otx.algo.classification.backbones * Fix unit-test * Fix docstring * Disable integration test in pr-merge workflow (#3677) * Add TV MaskRCNN Tile Recipe (#3655) * add tv maskrcnn recipe * add unit test * add tile size * fix bug * Align integration test to exportable code interface update for release branch (#3676) * align integration test to exportable code update * add error message * align vp expected output name * Refactor exporter for anomaly task and fix a bug with exportable code (#3672) * refactor exporter * remove *to * reply comments * resolve problem with local temp file * Fix NNCF MaskRCNN-Eff accuracy drop (#3680) * fix nncf maskrcnn eff accuracy drop * update ignored scope * fix typo * Update pandas version constraint (#3679) --------- Co-authored-by: Yunchu Lee <[email protected]> Co-authored-by: Prokofiev Kirill <[email protected]> Co-authored-by: Eugene Liu <[email protected]> Co-authored-by: Eunwoo Shin <[email protected]>
* [hotfix] Update for fix workflow issues (#3668) * Update README & CODEOWNERS (#3659) * Update Engine's docstring & CLI --help outputs (#3658) Update Engine's CLI docstring & HelpFormatter * Fix unit test for semantic segmentation to run it without mmseg (#3670) fix test to run wo mm * Enable ruff & ruff-format into otx/algo/classification/backbones (#3667) * Enable ruff in otx.algo.classification.backbones * Fix unit-test * Fix docstring * Disable integration test in pr-merge workflow (#3677) * Add TV MaskRCNN Tile Recipe (#3655) * add tv maskrcnn recipe * add unit test * add tile size * fix bug * Align integration test to exportable code interface update for release branch (#3676) * align integration test to exportable code update * add error message * align vp expected output name * Refactor exporter for anomaly task and fix a bug with exportable code (#3672) * refactor exporter * remove *to * reply comments * resolve problem with local temp file * Fix NNCF MaskRCNN-Eff accuracy drop (#3680) * fix nncf maskrcnn eff accuracy drop * update ignored scope * fix typo * Update pandas version constraint (#3679) * Include more models to export test into test_otx_e2e (#3678) * enable export test * re-enable failed models * exclude exportable code test from anomaly task * apply it to e2e test code * align with pre-commit * Fix optimize with Semi-SL data pipeline (#3684) Disable unlabeled dataset with optimize * Fix MaskRCNN SwinT NNCF Accuracy Drop (#3685) fix swin-t nncf kinda * Bump MAPI version (#3686) * Add rotated det OV recipe (#3687) * Add rotated det ov recipe * fix e2e test cli * Move assigning tasks to Models from Engine to Anomaly Model Classes (#3683) * Move Task assign into Model with Anomaly Task * Fix openvino model class * Refactoring detection modules (#3636) * Organize common functions that are located in each det model into OTXDetectionModel - __init__, _build_model, _create_model, _customize_inputs, _customize_outputs, get_classification_layers * Create common directory for modules used across tasks * Remove DictConfig to use dict instead * Update docstring * Refactoring - export related things - grouped importing backbones, necks, heads, losses - move assigners, coders, prior_generators, samplers which are located in heads to utils * Fix segmentation fault on VPM PTQ (#3689) Add forcing `num_workers` to 0 * Fix detection performance degradation (#3691) Update to apply filtering to only `test_step` and `predict_step` not to affect training * Bump datumaro to 1.7.0 (#3669) * bump datumaro to 1.7.0 * apply changes on datumaro 1.7.0 * Add maskrcnn_r50_tv_tile (#3692) * Update version string and fill missing changelog (#3693) --------- Co-authored-by: Harim Kang <[email protected]> Co-authored-by: Prokofiev Kirill <[email protected]> Co-authored-by: Eugene Liu <[email protected]> Co-authored-by: Eunwoo Shin <[email protected]> Co-authored-by: Vladislav Sovrasov <[email protected]> Co-authored-by: Kim, Sungchul <[email protected]> Co-authored-by: Emily Chun <[email protected]>
Summary
Fix CVS-144836. Refactor a bit exporter to look similar to other tasks.
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.