Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rotated detection data pipeline #3627

Conversation

eugene123tw
Copy link
Contributor

Summary

Fix rotated detection data pipeline

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have ran e2e tests and there is no issues.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2024 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eugene123tw eugene123tw requested a review from a team as a code owner June 17, 2024 14:10
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jun 17, 2024
@sovrasov
Copy link
Contributor

Can we use src/otx/algorithms/detection/configs/base/data/iseg_efficientnet_data_pipeline.py and other similar configs as a data pipeline for rotated det as well?

@sovrasov
Copy link
Contributor

Thanks for the prompt fix!

@eugene123tw
Copy link
Contributor Author

Can we use src/otx/algorithms/detection/configs/base/data/iseg_efficientnet_data_pipeline.py and other similar configs as a data pipeline for rotated det as well?

It makes sense to use the same file; however, I didn't use it because different tasks have different domain names in the training pipeline. Thus, I can't use the same file without finding a way to overwrite the domain (see the pipeline below). To avoid further breaking changes, I only fixed the keep_ratio part.

train_pipeline = [
    dict(
        type="LoadResizeDataFromOTXDataset",
        load_ann_cfg=dict(
            type="LoadAnnotationFromOTXDataset",
            domain="rotated_detection",
            with_bbox=True,
            with_mask=True,
            poly2mask=False,
        ),
        resize_cfg=dict(
            type="Resize",
            img_scale=__img_size,
            keep_ratio=False,
        ),
        enable_memcache=True,  # Cache after resizing image & annotations
    ),
]

@chuneuny-emily
Copy link
Contributor

@eugene123tw - Could you ensure future refactoring aligns with previous configurations or provide experiment results on changes? This would help in tracking changes and preventing potential issues like the recent performance drop. https://github.com/openvinotoolkit/training_extensions/blob/releases/1.2.4/otx/algorithms/detection/configs/rotated_detection/efficientnetb2b_maskrcnn/data_pipeline.py

@chuneuny-emily chuneuny-emily merged commit 105efa4 into openvinotoolkit:releases/1.6.0 Jun 18, 2024
14 checks passed
@chuneuny-emily
Copy link
Contributor

@eugene123tw - If this issue reproduces with OTX2.0.0, please make sure to create one more fix for develop branch.

@eugene123tw eugene123tw deleted the eugene/CVS-143626-fix-rot-det-data-pipeline branch June 18, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants