Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply load+resize cache to validation pipelines #2463

Merged

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Aug 30, 2023

Summary

[Changes]

  • Applied LoadResizeDataFromOTXDataset to validation pipeline to optimize efficiency & memory usage
    (Separated from test pipeline)
  • Fixed minor issue: re-enable AdaptClassLabel op

[Results]

Task Dataset Model Branch Cache usage E2E time
Classification CUB_200_2011_64 (<500x500) EFFb0 (224x224) develop (org 35M) 9M 10.03
      opt/load-resize-cache-val 1M 9.05
Detection peanut (1920x1080) YOLOX (640x640) develop (org 168M) 64M 32.05
      opt/load-resize-cache-val 18M 32.19
Instance seg wgisd (2048x1365) MRCNN-EFFb0 (1042x1024) develop (org 942M) 271M 298.92
      opt/load-resize-cache-val 22M 237.91
Semantic seg kvasir_seg/100 (500x500 ~ 1Kx1K) LiteHRNet_s_mod2 (512x512) develop (org 95M) 30M 37.64
      opt/load-resize-cache-val 22M 36.75
[!] org cache usage: caching original decoded image

How to test

  • Integration test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81 goodsong81 added the ENHANCE Enhancement of existing features label Aug 30, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Aug 30, 2023
@goodsong81 goodsong81 marked this pull request as ready for review August 30, 2023 06:29
@goodsong81 goodsong81 requested a review from a team as a code owner August 30, 2023 06:29
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I have a minor question. Why isn't it applied to test pipeline?

@sungmanc
Copy link
Contributor

LGTM, but I have a minor question. Why isn't it applied to test pipeline?

IMO, we call val_data at every epoch, however, only call test_data at once. so, don't need to cache the data

@goodsong81 goodsong81 merged commit fc6386c into openvinotoolkit:develop Aug 30, 2023
@goodsong81 goodsong81 deleted the opt/load-resize-cache-val branch August 30, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation ENHANCE Enhancement of existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants