-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge load / resize / cache to optimize data loading efficiency for classification #2438
Merged
goodsong81
merged 15 commits into
openvinotoolkit:develop
from
goodsong81:feat/load-resize-cache
Aug 22, 2023
Merged
Merge load / resize / cache to optimize data loading efficiency for classification #2438
goodsong81
merged 15 commits into
openvinotoolkit:develop
from
goodsong81:feat/load-resize-cache
Aug 22, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
github-actions
bot
added
ALGO
Any changes in OTX Algo Tasks implementation
TEST
Any changes in tests
labels
Aug 18, 2023
Signed-off-by: Songki Choi <[email protected]>
eunwoosh
previously approved these changes
Aug 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work! LGTM but I have some questions. please take a look.
src/otx/algorithms/classification/configs/base/data/data_pipeline.py
Outdated
Show resolved
Hide resolved
sungmanc
reviewed
Aug 18, 2023
src/otx/algorithms/common/adapters/mmcv/pipelines/load_image_from_otx_dataset.py
Show resolved
Hide resolved
src/otx/algorithms/classification/adapters/mmcls/datasets/pipelines/otx_pipelines.py
Show resolved
Hide resolved
Signed-off-by: Songki Choi <[email protected]>
jaegukhyun
previously approved these changes
Aug 21, 2023
Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Songki Choi <[email protected]>
eunwoosh
previously approved these changes
Aug 22, 2023
8 tasks
Signed-off-by: Songki Choi <[email protected]>
sungmanc
approved these changes
Aug 22, 2023
eunwoosh
approved these changes
Aug 22, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
[Changes]
LoadResizeDataFromOTXDataset
to merge & wrapLoadImageFromOTXDataset
LoadAnnotationFromOTXDataset
Resize
ResizeTo
to runResize
only if the expected size is different from current size[Results]
How to test
[Example CMD]
Checklist
License
Feel free to contact the maintainers if that's a concern.