-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable ViTReciproCAM for VisionTransformer backbone (cls task) #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ALGO
Any changes in OTX Algo Tasks implementation
TEST
Any changes in tests
labels
Jul 26, 2023
negvet
changed the title
Enable ViTReciproCAM for deit
Enable ViTReciproCAM for VisionTransformer backbone (cls task)
Jul 31, 2023
jaegukhyun
previously approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eunwoosh
reviewed
Aug 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your effort :) I left some comments. please take a look.
src/otx/algorithms/classification/adapters/mmcls/models/classifiers/custom_image_classifier.py
Show resolved
Hide resolved
sovrasov
reviewed
Aug 1, 2023
src/otx/algorithms/classification/adapters/mmcls/models/classifiers/custom_image_classifier.py
Outdated
Show resolved
Hide resolved
src/otx/algorithms/classification/adapters/mmcls/models/classifiers/custom_image_classifier.py
Outdated
Show resolved
Hide resolved
sovrasov
reviewed
Aug 1, 2023
src/otx/algorithms/classification/adapters/mmcls/models/classifiers/custom_image_classifier.py
Outdated
Show resolved
Hide resolved
jaegukhyun
previously approved these changes
Aug 2, 2023
sovrasov
approved these changes
Aug 2, 2023
sungmanc
approved these changes
Aug 3, 2023
eunwoosh
approved these changes
Aug 3, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enable ViTReciproCAM to support cls models with
VisionTransformer
backbone, e.g. deit.Can be merged, but cannot be actually used in Geti until #2098 is resoled (featute vector and saliency maps are coupled). Can be used right away only for torch runtime.
Validated in OTX:
Torch task examples:
OV task examples:
Multilabel:
How to test
Checklist
License
Feel free to contact the maintainers if that's a concern.