Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a performance drop while training EfficientNetV2 with multi-GPU #2398

Merged
merged 5 commits into from
Jul 26, 2023

Conversation

eunwoosh
Copy link
Contributor

Summary

This PR fixes #2253
The reason of performance drop is not to use a function converting BatchNorm to SyncBatchNorm from timm.
There is additional code in timm's function to deal with some cases in timm's model, so I should have used that function for models from timm like EfficientNetV2.
So, I changed code to use timm's function for timm's model.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@eunwoosh eunwoosh added the FIX defect fix label Jul 25, 2023
@eunwoosh eunwoosh added this to the 1.5.0 milestone Jul 25, 2023
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels Jul 25, 2023
@eunwoosh eunwoosh marked this pull request as ready for review July 26, 2023 01:53
@eunwoosh eunwoosh requested a review from a team as a code owner July 26, 2023 01:53
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eunwoosh eunwoosh merged commit 9d60945 into openvinotoolkit:develop Jul 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation FIX defect fix TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Large accuracy drop on Custom_Image_Classification_EfficientNet-V2-S with 2 GPUs
3 participants