Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add description & remove unused configurable parameters #2382

Conversation

goodsong81
Copy link
Contributor

@goodsong81 goodsong81 commented Jul 20, 2023

Summary

  • Add description for learning_rate_warm_up_iter
  • Remove unused num_checkpoints & learning_rate_fixed_iters

How to test

  • n/a

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@goodsong81 goodsong81 added the ENHANCE Enhancement of existing features label Jul 20, 2023
@goodsong81 goodsong81 added this to the 1.5.0 milestone Jul 20, 2023
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 20, 2023
Signed-off-by: Songki Choi <[email protected]>
@github-actions github-actions bot added the TEST Any changes in tests label Jul 21, 2023
@goodsong81 goodsong81 marked this pull request as ready for review July 21, 2023 02:37
@goodsong81 goodsong81 requested a review from a team as a code owner July 21, 2023 02:37
@goodsong81 goodsong81 merged commit bb6ae77 into openvinotoolkit:develop Jul 21, 2023
@goodsong81 goodsong81 deleted the fix/add-descr-remove-unused-param branch July 21, 2023 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation ENHANCE Enhancement of existing features TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants