Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added fix-cpu numbers option #2340

Merged
merged 2 commits into from
Jul 12, 2023
Merged

added fix-cpu numbers option #2340

merged 2 commits into from
Jul 12, 2023

Conversation

yunchu
Copy link
Contributor

@yunchu yunchu commented Jul 11, 2023

Summary

add an option to specify number of CPUs for the actions-runner CI container

@yunchu yunchu requested a review from a team as a code owner July 11, 2023 13:17
@github-actions github-actions bot added the BUILD label Jul 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 11, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (685d096) 79.63% compared to head (feceef1) 79.63%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2340   +/-   ##
========================================
  Coverage    79.63%   79.63%           
========================================
  Files          509      509           
  Lines        37983    37983           
========================================
  Hits         30246    30246           
  Misses        7737     7737           
Flag Coverage Δ
py310 79.62% <ø> (-0.01%) ⬇️
py38 79.57% <ø> (ø)
py39 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this option required to avoid the CPU bottleneck..?

@yunchu
Copy link
Contributor Author

yunchu commented Jul 12, 2023

Is this option required to avoid the CPU bottleneck..?

I thing so. actually, I hope this option to use ci instance for the regression testing. by fixing number of CPUs for each container, I think we can get the constant performance from every runs of regression testing.

@yunchu yunchu added the CI Any changes in CI setting label Jul 12, 2023
@yunchu yunchu merged commit 815c852 into develop Jul 12, 2023
@yunchu yunchu deleted the infra/update-ci-script-fix-cpu branch July 12, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BUILD CI Any changes in CI setting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants