Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable DINO to OTX - Step 2. Upgrade Deformable DETR to DINO #2266

Merged
merged 11 commits into from
Jun 27, 2023
Merged

Enable DINO to OTX - Step 2. Upgrade Deformable DETR to DINO #2266

merged 11 commits into from
Jun 27, 2023

Conversation

jaegukhyun
Copy link
Contributor

@jaegukhyun jaegukhyun commented Jun 23, 2023 •
edited
Loading

Summary

This PR is for upgrading Deformable DETR to DINO.
Since DINO is only able to use in mmdet3.x. Some of modules are come from mmdet3.x.
From this PR, otx can train, eval, export DINO.

Next PR will contain

  1. Enable early stopping and reduced lr plateau decay.
  2. Add FLOPs and MB for DINO and Deformable DETR.
  3. Add documentation.
  4. (Optional) Smart weight loading.

How to test

Unit, Intg
** E2E tests will be added in next PR.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM TEST Any changes in tests DOC Improvements or additions to documentation labels Jun 23, 2023
@jaegukhyun jaegukhyun force-pushed the dino2 branch 2 times, most recently from 1b4ef0a to 3c33ab0 Compare June 26, 2023 02:00
@jaegukhyun jaegukhyun marked this pull request as ready for review June 26, 2023 05:41
@jaegukhyun jaegukhyun requested a review from a team as a code owner June 26, 2023 05:41
eunwoosh
eunwoosh reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I think it should be not easy work.
I left some comments please take a look.

otx/algorithms/detection/adapters/mmdet/models/detectors/custom_dino_detector.py Outdated Show resolved Hide resolved
otx/algorithms/detection/adapters/mmdet/models/detectors/custom_dino_detector.py Outdated Show resolved Hide resolved
otx/algorithms/detection/adapters/mmdet/models/layers/dino.py Outdated Show resolved Hide resolved
otx/algorithms/detection/adapters/mmdet/models/layers/dino.py Outdated Show resolved Hide resolved
otx/algorithms/detection/adapters/mmdet/models/layers/dino.py Outdated Show resolved Hide resolved
otx/algorithms/detection/configs/detection/resnet50_dino/data_pipeline.py Outdated Show resolved Hide resolved
otx/algorithms/detection/configs/detection/resnet50_dino/model.py Show resolved Hide resolved
otx/algorithms/detection/configs/detection/resnet50_dino/template_experimental.yaml Show resolved Hide resolved
sungmanc
sungmanc reviewed Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the great work.

otx/algorithms/detection/configs/detection/resnet50_dino/data_pipeline.py Outdated Show resolved Hide resolved
eunwoosh
eunwoosh previously approved these changes Jun 27, 2023
View reviewed changes
sungmanc
sungmanc previously approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaegukhyun jaegukhyun dismissed stale reviews from sungmanc and eunwoosh via d893e1a June 27, 2023 06:35
@jaegukhyun jaegukhyun requested review from sungmanc and eunwoosh June 27, 2023 07:50
@jaegukhyun jaegukhyun merged commit f974b41 into openvinotoolkit:develop Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eunwoosh eunwoosh eunwoosh approved these changes

@sungmanc sungmanc sungmanc approved these changes

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaegukhyun @sungmanc @eunwoosh