-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add supcon seg for regression #2177
Merged
sungmanc
merged 7 commits into
openvinotoolkit:releases/1.3.0
from
sungmanc:add-supcon-seg
May 24, 2023
Merged
Add supcon seg for regression #2177
sungmanc
merged 7 commits into
openvinotoolkit:releases/1.3.0
from
sungmanc:add-supcon-seg
May 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ALGO
Any changes in OTX Algo Tasks implementation
TEST
Any changes in tests
labels
May 23, 2023
* Fix det e2e * Fix mypy
sungchul2
reviewed
May 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left some minor comments.
otx/algorithms/segmentation/configs/ocr_lite_hrnet_18/supcon/__init__.py
Outdated
Show resolved
Hide resolved
otx/algorithms/segmentation/configs/ocr_lite_hrnet_18/supcon/model.py
Outdated
Show resolved
Hide resolved
sungmanc
commented
May 24, 2023
otx/algorithms/segmentation/configs/ocr_lite_hrnet_18/supcon/__init__.py
Outdated
Show resolved
Hide resolved
otx/algorithms/segmentation/configs/ocr_lite_hrnet_18/supcon/model.py
Outdated
Show resolved
Hide resolved
sungchul2
previously approved these changes
May 24, 2023
jaegukhyun
previously approved these changes
May 24, 2023
jaegukhyun
dismissed stale reviews from sungchul2 and themself
May 24, 2023 06:18
The base branch was changed.
jaegukhyun
approved these changes
May 24, 2023
sungchul2
approved these changes
May 24, 2023
goodsong81
added a commit
that referenced
this pull request
Jun 5, 2023
* Fix e2e (#2179) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update noisy label det docs for detection task (#2183) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Add supcon seg for regression (#2177) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Update regression test config (#2186) * Fix for anomaly regression test (#2188) * Fix iseg regression (#2190) * Set path to save pseudo masks into workspace (#2185) * Temporary fix override_configs bug (#2187) * Fix iseg e2e (#2173) * Fix det e2e (#2176) * Cleaned up skip/xfail TCs on the classification e2e tests (#2196) * Added csv output to export dependencies (#2178) * Fix typo and enlarge the threshold for KPI tests (#2198) * bugfix: auto adapt batch size doesn't work with cls incr case (#2199) * Fix for ssd (#2197) * Turn off persistent worker if num_worker is zero in classification task (#2208) * Update test cases of common_semantic_segmentation_dataset (#2210) * Optimize counting train & inference speed and memory consumption (#2172) * Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174) * Add warning message to tiling parameter (#2193) * Change the way to pad for instance-segmentation * Hotfix: use 0 confidence threshold when computing best threshold based on F1 * Fix possible bw issue in exportable code (#2212) * Fix ellipse load (#2214) * Fix GT vs prediction order mismatch due to different sorting result (#2216) * Return raw anomaly maps as metadata (#2217) * Fix merge error, revert to pymongo w/o version spec --------- Signed-off-by: Songki Choi <[email protected]> Signed-off-by: Kim, Vinnam <[email protected]> Co-authored-by: Jaeguk Hyun <[email protected]> Co-authored-by: Vinnam Kim <[email protected]> Co-authored-by: Sungman Cho <[email protected]> Co-authored-by: Eunwoo Shin <[email protected]> Co-authored-by: Kim, Sungchul <[email protected]> Co-authored-by: Yunchu Lee <[email protected]> Co-authored-by: Jihwan Eom <[email protected]> Co-authored-by: Eugene Liu <[email protected]> Co-authored-by: sungmanc <[email protected]> Co-authored-by: Vladislav Sovrasov <[email protected]> Co-authored-by: Dick Ameln <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Issue number: #2171
This PR includes the supcon tests for regression.
How to test
tox -e tests-all-py310 -- tests/regression/semantic_segmentation/test_segmentation.py::TestRegressionSupconSegmentation
Checklist
License
Feel free to contact the maintainers if that's a concern.