Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supcon seg for regression #2177

Merged
merged 7 commits into from
May 24, 2023

Conversation

sungmanc
Copy link
Contributor

Summary

Issue number: #2171

This PR includes the supcon tests for regression.

How to test

tox -e tests-all-py310 -- tests/regression/semantic_segmentation/test_segmentation.py::TestRegressionSupconSegmentation
image

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sungmanc sungmanc requested a review from a team as a code owner May 23, 2023 07:32
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests labels May 23, 2023
@sungmanc sungmanc requested review from sungchul2 and jaegukhyun May 24, 2023 00:50
Copy link
Contributor

@sungchul2 sungchul2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left some minor comments.

sungchul2
sungchul2 previously approved these changes May 24, 2023
jaegukhyun
jaegukhyun previously approved these changes May 24, 2023
@jaegukhyun jaegukhyun changed the base branch from develop to releases/1.3.0 May 24, 2023 06:18
@jaegukhyun jaegukhyun dismissed stale reviews from sungchul2 and themself May 24, 2023 06:18

The base branch was changed.

@jaegukhyun jaegukhyun requested a review from sungchul2 May 24, 2023 06:19
@sungmanc sungmanc merged commit 85ce846 into openvinotoolkit:releases/1.3.0 May 24, 2023
goodsong81 added a commit that referenced this pull request Jun 5, 2023
* Fix e2e (#2179)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update noisy label det docs for detection task (#2183)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Add supcon seg for regression (#2177)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Update regression test config (#2186)

* Fix for anomaly regression test (#2188)

* Fix iseg regression (#2190)

* Set path to save pseudo masks into workspace (#2185)

* Temporary fix override_configs bug (#2187)

* Fix iseg e2e (#2173)

* Fix det e2e (#2176)

* Cleaned up skip/xfail TCs on the classification e2e tests (#2196)

* Added csv output to export dependencies (#2178)

* Fix typo and enlarge the threshold for KPI tests (#2198)

* bugfix: auto adapt batch size doesn't work with cls incr case (#2199)

* Fix for ssd (#2197)

* Turn off persistent worker if num_worker is zero in classification task (#2208)

* Update test cases of common_semantic_segmentation_dataset (#2210)

* Optimize counting train & inference speed and memory consumption (#2172)

* Do not skip full img tile classifier + Fix Sequencial Export Issue (#2174)

* Add warning message to tiling parameter (#2193)

* Change the way to pad for instance-segmentation

* Hotfix: use 0 confidence threshold when computing best threshold based on F1

* Fix possible bw issue in exportable code (#2212)

* Fix ellipse load (#2214)

* Fix GT vs prediction order mismatch due to different sorting result (#2216)

* Return raw anomaly maps as metadata (#2217)

* Fix merge error, revert to pymongo w/o version spec

---------

Signed-off-by: Songki Choi <[email protected]>
Signed-off-by: Kim, Vinnam <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
Co-authored-by: Vinnam Kim <[email protected]>
Co-authored-by: Sungman Cho <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Kim, Sungchul <[email protected]>
Co-authored-by: Yunchu Lee <[email protected]>
Co-authored-by: Jihwan Eom <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: sungmanc <[email protected]>
Co-authored-by: Vladislav Sovrasov <[email protected]>
Co-authored-by: Dick Ameln <[email protected]>
@sungmanc sungmanc deleted the add-supcon-seg branch July 24, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants