Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standalone onnx export #2155

Merged
merged 22 commits into from
May 19, 2023
Merged

Standalone onnx export #2155

merged 22 commits into from
May 19, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented May 15, 2023 •
edited
Loading

Summary

New export type is introduced. Now task.export() method can directly generate onnx models, when corresponding export type is specified. Also, the export type could be specified via CLI.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov requested a review from a team as a code owner May 15, 2023 16:21
@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API CLI Any changes in OTE CLI TEST Any changes in tests labels May 15, 2023
@sovrasov sovrasov added this to the 1.3.0 milestone May 15, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label May 15, 2023
sungmanc
sungmanc reviewed May 15, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's nice progress ! I left minor comments.

otx/algorithms/classification/adapters/mmcls/task.py Outdated Show resolved Hide resolved
otx/algorithms/common/utils/mask_to_bbox.py Outdated Show resolved Hide resolved
otx/cli/tools/export.py Outdated Show resolved Hide resolved
tests/integration/cli/action/test_action_classification.py Show resolved Hide resolved
eunwoosh
eunwoosh reviewed May 16, 2023
View reviewed changes
Copy link
Contributor

@eunwoosh eunwoosh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! I left some comments. please take a look.

otx/algorithms/action/adapters/mmaction/utils/export_utils.py Outdated Show resolved Hide resolved
otx/algorithms/action/task.py Show resolved Hide resolved
@sovrasov sovrasov force-pushed the vs/separate_onnx_export branch 2 times, most recently from e9857a4 to 639a798 Compare May 16, 2023 13:42
sungmanc
sungmanc previously approved these changes May 17, 2023
View reviewed changes
eunwoosh
eunwoosh previously approved these changes May 17, 2023
View reviewed changes
@sovrasov sovrasov dismissed stale reviews from eunwoosh and sungmanc via 0ecddd7 May 17, 2023 08:59
@sovrasov sovrasov force-pushed the vs/separate_onnx_export branch 3 times, most recently from 6085270 to e6ae9f2 Compare May 17, 2023 09:35
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label May 17, 2023
@sovrasov
Copy link
Contributor Author

ONNX purity check is added: models should be compatible with onnxruntime

jaegukhyun
jaegukhyun previously approved these changes May 18, 2023
View reviewed changes
sungmanc
sungmanc previously approved these changes May 19, 2023
View reviewed changes
@sovrasov sovrasov dismissed stale reviews from sungmanc and jaegukhyun via 1a8e271 May 19, 2023 07:08
@sovrasov sovrasov merged commit 22b9b3a into openvinotoolkit:develop May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaegukhyun jaegukhyun jaegukhyun approved these changes

@sungmanc sungmanc sungmanc approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@eunwoosh eunwoosh eunwoosh left review comments

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation REFACTOR TEST Any changes in tests
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sovrasov @goodsong81 @sungmanc @eunwoosh @jaegukhyun