Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update OV / NNCF/ ModelAPI / Datumaro #2090

Merged
merged 118 commits into from
Jul 7, 2023

Conversation

sovrasov
Copy link
Contributor

@sovrasov sovrasov commented Apr 28, 2023

Summary

This PR updates OV-related dependencies of OTX.
Known issues:

  • OMZ plugin may fail in some cases, because version was set to opset1 by default for some of operations. This could be updated later, if we face models that show opset - version mismatch.
  • ModelAPI integration requires a deeper refactoring
  • MoViNet inference in OV doesn't work
  • Tile classifier is not handled by PTQ (as before)

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@sovrasov sovrasov marked this pull request as ready for review April 28, 2023 12:33
@sovrasov sovrasov requested a review from a team as a code owner April 28, 2023 12:33
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Apr 28, 2023
@sungmanc
Copy link
Contributor

sungmanc commented May 2, 2023

Small comment, if the PR is still in progress, please use DRAFT PR. we could use CI tests even in under the DRFAT status.

@sovrasov sovrasov marked this pull request as draft May 3, 2023 15:15
@yunchu
Copy link
Contributor

yunchu commented May 8, 2023

@sovrasov note that you can skip the automatic trigger of the actions for the test PR by adding string [skip ci] to your commit message.
https://github.blog/changelog/2021-02-08-github-actions-skip-pull-request-and-push-workflows-with-skip-ci/

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests labels Jun 1, 2023
@sovrasov sovrasov force-pushed the vs/upd_ov branch 2 times, most recently from 1da668d to 1a7dbcb Compare June 5, 2023 17:57
@sovrasov sovrasov marked this pull request as ready for review June 5, 2023 19:45
@sovrasov sovrasov added this to the 1.4.0 milestone Jun 5, 2023
@github-actions github-actions bot added the DOC Improvements or additions to documentation label Jun 6, 2023
@sovrasov sovrasov force-pushed the vs/upd_ov branch 3 times, most recently from 0eaa49f to b78e9da Compare June 12, 2023 13:41
@sovrasov sovrasov changed the title [Test, do not merge] Update ov to a pre-release version [Test, do not merge] Update OV 2023.0 version Jun 14, 2023
@sovrasov sovrasov force-pushed the vs/upd_ov branch 11 times, most recently from 3d96362 to 767a8cc Compare June 19, 2023 11:43
@github-actions github-actions bot added the CLI Any changes in OTE CLI label Jul 3, 2023
@sovrasov
Copy link
Contributor Author

sovrasov commented Jul 3, 2023

https://github.com/openvinotoolkit/training_extensions/actions/runs/5442410680 E2E Test from f8f3d67. Could you take a look? I have no idea for anomaly, but for detection, maybe data pipeline between normal detection and tiling would be different. Therefore eeabbca could affect it.

In the latest commits, PTQ was switched to POT via config (NCT team members suggested to do that).
Also, the issue with YOLOX tiling preprocessing was fixed.

@sovrasov
Copy link
Contributor Author

sovrasov commented Jul 4, 2023

@jaegukhyun could you launch e2e once again? I was unable to reproduce the anomaly deploy accuracy issue on my side

@jaegukhyun
Copy link
Contributor

https://github.com/openvinotoolkit/training_extensions/actions/runs/5460287541 I rerun e2e from deea851
Firstly @GalyaZalesskaya should solve current E2E and @sovrasov you need to update FQ reference for anomaly and segmentation

@jaegukhyun
Copy link
Contributor

Please rebase your branch, Galina's PR for e2e test failures is merged

jaegukhyun
jaegukhyun previously approved these changes Jul 7, 2023
Copy link
Contributor

@jaegukhyun jaegukhyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/openvinotoolkit/training_extensions/actions/runs/5473307857
All tests are passed, I think we can merge this PR. Thanks for your effort

@sovrasov sovrasov requested a review from sungmanc July 7, 2023 06:25
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, it's a huge update!

CHANGELOG.md Show resolved Hide resolved
@goodsong81 goodsong81 merged commit 7027132 into openvinotoolkit:develop Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API CLI Any changes in OTE CLI DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants