Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add greedy labels resolver #2064

Merged
merged 5 commits into from
May 10, 2023
Merged

Add greedy labels resolver #2064

merged 5 commits into from
May 10, 2023

Conversation

sovrasov
Copy link
Contributor

Summary

This PR adds a simplified algorithm for resolving labels in hierarchical classification.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added API Any changes in OTX API TEST Any changes in tests DOC Improvements or additions to documentation labels Apr 24, 2023
@sovrasov sovrasov marked this pull request as ready for review April 24, 2023 16:21
@sovrasov sovrasov requested a review from a team as a code owner April 24, 2023 16:21
sungmanc
sungmanc previously approved these changes Apr 25, 2023
View reviewed changes
@sovrasov sovrasov force-pushed the vs/simplify_label_res branch from 1f6aeba to 047cccd Compare April 25, 2023 08:53
@sovrasov sovrasov requested review from AlexKoff88 and Wovchena April 25, 2023 11:30
Wovchena
Wovchena previously approved these changes Apr 25, 2023
View reviewed changes
otx/api/entities/label_schema.py Outdated Show resolved Hide resolved
otx/api/entities/label_schema.py Outdated Show resolved Hide resolved
AlexKoff88
AlexKoff88 previously approved these changes Apr 25, 2023
View reviewed changes
@sovrasov sovrasov dismissed stale reviews from AlexKoff88 and Wovchena via d6d42d8 April 25, 2023 14:51
@sungmanc sungmanc added this to the 1.3.0 milestone Apr 26, 2023
@sovrasov sovrasov force-pushed the vs/simplify_label_res branch 2 times, most recently from dc470d6 to d893ba3 Compare May 9, 2023 07:50
AlexKoff88
AlexKoff88 previously approved these changes May 9, 2023
View reviewed changes
@sovrasov
Copy link
Contributor Author

@goodsong81 @sungmanc could you have a look?

sungmanc
sungmanc approved these changes May 10, 2023
View reviewed changes
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sovrasov sovrasov requested a review from goodsong81 May 10, 2023 07:38
@sovrasov sovrasov merged commit b47e2c5 into openvinotoolkit:develop May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungmanc sungmanc sungmanc approved these changes

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@Wovchena Wovchena Wovchena left review comments

Assignees
No one assigned
Labels
API Any changes in OTX API DOC Improvements or additions to documentation TEST Any changes in tests
Projects
None yet
Milestone
1.3.0
Development

Successfully merging this pull request may close these issues.
5 participants
@sovrasov @goodsong81 @Wovchena @AlexKoff88 @sungmanc