Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiling Spatial Concatenation for OpenVINO IR #2052

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw commented Apr 21, 2023

Summary

To optimize the inference process of an IR model, adjusting tiling parameters can be effective. For example, during training, 16x16 tiles with 100x100 pixels may be used. However, during inference, 8x8 tiles with 200x200 pixels can be used after reshaping the IR model once. This change can result in a 1/4 reduction in the number of calls, with expected internal parallelization in the OpenVINO runtime.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added e2e tests for validation.
  • I have added the description of my changes into CHANGELOG in my target branch (e.g., CHANGELOG in develop).​
  • I have updated the documentation in my target branch accordingly (e.g., documentation in develop).
  • I have linked related issues.

License

  • I submit my code changes under the same Apache License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
# SPDX-License-Identifier: Apache-2.0

@github-actions github-actions bot added ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API TEST Any changes in tests labels Apr 21, 2023
@eugene123tw eugene123tw changed the title Eugene/cvs 102977 spatial concatenation Tiling Spatial Concatenation for OpenVINO IR Apr 25, 2023
@eugene123tw eugene123tw marked this pull request as ready for review April 25, 2023 18:33
@eugene123tw eugene123tw requested a review from a team as a code owner April 25, 2023 18:33
Copy link
Contributor

@sungmanc sungmanc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, LGTM. BTW, could you attach the experimental results in description?

@sungmanc sungmanc modified the milestones: 1.3.0, 1.2.0 Apr 26, 2023
@sungmanc sungmanc added FEATURE New feature & functionality RELEASE labels Apr 26, 2023
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the great enhancement. LGTM if test failures are fixed.

otx/algorithms/common/configs/training_base.py Outdated Show resolved Hide resolved
@goodsong81 goodsong81 added ENHANCE Enhancement of existing features and removed FEATURE New feature & functionality labels Apr 27, 2023
@goodsong81 goodsong81 merged commit 3dcef4b into openvinotoolkit:releases/1.2.1 Apr 27, 2023
goodsong81 pushed a commit to goodsong81/training_extensions that referenced this pull request May 2, 2023
* draft

* udpate pytest skip tag

* add spatial concatenation

* code quality fixes

* fix tests

* add unit test for ir scale factor

* revert pytest skip and address test failure in another PR

* refactor variable name
goodsong81 added a commit that referenced this pull request May 3, 2023
* Upgrade mmdeploy==0.14.0 from official PyPI (#2047)

* Bug fix: value of validation variable is changed after auto decrease batch size (#2053)

* Integrate new ignored loss in semantic segmentation (#2065)

* Remove unused modules in semantic segmentation (#2068)

* Add doc for fast data loading (#2069)

* Bug fix: set gpu_ids properly (#2071)

* Bug fix: Progress goes 100% and back 0 % repeatedly during auto decrease bs in Geti (#2074)

* Fix tiling 0 stride issue in parameter adapter (#2078)

* Update instance-segmentation tutorial documentation (#2082)

* Optimize YOLOX data pipeline and add unit test for get_subset of Datu… (#2075)

* Tiling Spatial Concatenation for OpenVINO IR (#2052)

* Add spatial concatenation to deployment demo (#2089)

---------

Signed-off-by: Songki Choi <[email protected]>
Co-authored-by: Eunwoo Shin <[email protected]>
Co-authored-by: Soobee Lee <[email protected]>
Co-authored-by: Inhyuk Cho <[email protected]>
Co-authored-by: Eugene Liu <[email protected]>
Co-authored-by: Harim Kang <[email protected]>
Co-authored-by: Jaeguk Hyun <[email protected]>
@eugene123tw eugene123tw deleted the eugene/CVS-102977-spatial-concatenation branch May 7, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API ENHANCE Enhancement of existing features RELEASE TEST Any changes in tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants