Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OTE][develop] Add tiling in rotated detection #1420

Merged
merged 10 commits into from
Dec 20, 2022
Merged

[OTE][develop] Add tiling in rotated detection #1420

merged 10 commits into from
Dec 20, 2022

Conversation

eugene123tw
Copy link
Contributor

No description provided.

@eugene123tw eugene123tw marked this pull request as ready for review December 7, 2022 12:24
@eugene123tw eugene123tw requested a review from a team as a code owner December 7, 2022 12:24
@github-actions github-actions bot added API Any changes in OTX API ALGO Any changes in OTX Algo Tasks implementation labels Dec 7, 2022
@eugene123tw eugene123tw changed the base branch from develop to releases/v0.4.0-geti1.1.0 December 7, 2022 13:00
@eugene123tw eugene123tw changed the base branch from releases/v0.4.0-geti1.1.0 to develop December 7, 2022 13:01
@github-actions github-actions bot added the DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM label Dec 7, 2022
goodsong81
goodsong81 requested changes Dec 8, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve conflict and replicate this PR to releases/v0.4.0-geti1.1.0 branch.

@eugene123tw eugene123tw requested a review from sungmanc December 8, 2022 10:37
@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/825/

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/831/

goodsong81
goodsong81 previously approved these changes Dec 12, 2022
View reviewed changes
@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/832/

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/835/

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/838/

@sungmanc sungmanc changed the title Add tiling in rotated detection [OTE][develop] Add tiling in rotated detection Dec 14, 2022
@eugene123tw
Copy link
Contributor Author

@goodsong81 Could you have another look? All related tests passed except 1 failed case related to Inst-Seg OpenVINO accuracy assertion check.

goodsong81
goodsong81 previously approved these changes Dec 15, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

goodsong81
goodsong81 approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@goodsong81 goodsong81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already verified in the release branch. Merging this PR.

@goodsong81 goodsong81 merged commit f2fc56e into develop Dec 20, 2022
@goodsong81 goodsong81 deleted the eugene/CVS-98663-enable-tiling-oriented-bb branch December 20, 2022 01:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodsong81 goodsong81 goodsong81 approved these changes

@harimkang harimkang Awaiting requested review from harimkang

@sungmanc sungmanc Awaiting requested review from sungmanc

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation API Any changes in OTX API DEPENDENCY Any changes in any dependencies (new dep or its version) should be produced via Change Request on PM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eugene123tw @goodsong81 @sungmanc