Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MPA Detection] enable saliency map detection #1155

Merged
merged 9 commits into from
Jul 15, 2022
Merged

[MPA Detection] enable saliency map detection #1155

merged 9 commits into from
Jul 15, 2022

Conversation

eugene123tw
Copy link
Contributor

@eugene123tw eugene123tw requested a review from a team as a code owner July 6, 2022 14:58
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jul 6, 2022
@eugene123tw eugene123tw requested a review from goodsong81 July 6, 2022 15:00
@eugene123tw eugene123tw requested a review from harimkang July 7, 2022 09:27
@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/435/

@eugene123tw eugene123tw requested a review from JihwanEom July 12, 2022 11:15
JihwanEom
JihwanEom previously approved these changes Jul 12, 2022
View reviewed changes
Copy link
Contributor

@JihwanEom JihwanEom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

external/model-preparation-algorithm/mpa_tasks/apis/detection/task.py Outdated Show resolved Hide resolved
harimkang
harimkang suggested changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code contents seem to be clear. But the change in the submodule seems a little strange, is it right for the develop branch? It seems necessary to match the submodule commit.

harimkang
harimkang previously approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mistaken about the comment above. I mistook both the ote and mpa for develop branch.
LGTM

@harimkang
Copy link
Contributor

Pretty big PR just got merged. Please correct the MPA submodule (develop branch) and MPA task as part of it has been changed.

@eugene123tw eugene123tw dismissed stale reviews from harimkang and JihwanEom via f27e7a9 July 13, 2022 10:59
@eugene123tw
Copy link
Contributor Author

run ote-test

@eugene123tw
Copy link
Contributor Author

https://ci-ote.iotg.sclab.intel.com/job/ote/job/pr-ote-test/436/

@eugene123tw
Copy link
Contributor Author

@harimkang Thanks for the review. I have merged the latest commit from develop branch

harimkang
harimkang approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eugene123tw eugene123tw changed the title [Detection] enable saliency map detection [MPA Detection] enable saliency map detection Jul 14, 2022
@harimkang harimkang merged commit eb2735f into develop Jul 15, 2022
@harimkang harimkang deleted the eugene/CVS-86546-enable-saliency-map-detection branch July 15, 2022 06:32
jaegukhyun pushed a commit that referenced this pull request Jul 15, 2022
@eugene123tw @jaegukhyun
[MPA Detection] enable saliency map detection (#1155)
60f0da3 
* output saliency map and feature vector for MPA detection algo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuneuny-emily chuneuny-emily chuneuny-emily approved these changes

@harimkang harimkang harimkang approved these changes

@goodsong81 goodsong81 goodsong81 approved these changes

@JihwanEom JihwanEom Awaiting requested review from JihwanEom

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eugene123tw @harimkang @goodsong81 @chuneuny-emily @JihwanEom