Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable balanced sampler for class incremental learning #1139

Merged
merged 14 commits into from
Jun 22, 2022
Merged

Enable balanced sampler for class incremental learning #1139

merged 14 commits into from
Jun 22, 2022

Conversation

supersoob
Copy link
Contributor

This PR includes:

  • Modified dataset codes
  • Create data_utils.py to get separated indices for each class

@supersoob supersoob requested a review from a team as a code owner June 16, 2022 02:45
@github-actions github-actions bot added the ALGO Any changes in OTX Algo Tasks implementation label Jun 16, 2022
harimkang
harimkang suggested changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mpa submodule update appears to be missing. Please update it.

external/model-preparation-algorithm/mpa_tasks/utils/data_utils.py Show resolved Hide resolved
external/model-preparation-algorithm/mpa_tasks/utils/data_utils.py Outdated Show resolved Hide resolved
external/model-preparation-algorithm/mpa_tasks/extensions/datasets/mpa_seg_dataset.py Outdated Show resolved Hide resolved
chuneuny-emily
chuneuny-emily previously approved these changes Jun 20, 2022
View reviewed changes
JihwanEom
JihwanEom approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@JihwanEom JihwanEom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

harimkang
harimkang reviewed Jun 21, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you reply to the comment, I will approve it.
Is there no need to run ote-test in this PR?

external/model-preparation-algorithm/mpa_tasks/apis/task.py Show resolved Hide resolved
@supersoob
Copy link
Contributor Author

run ote-test

harimkang
harimkang approved these changes Jun 21, 2022
View reviewed changes
Copy link
Contributor

@harimkang harimkang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@supersoob supersoob merged commit db8dac3 into develop Jun 22, 2022
@supersoob supersoob deleted the ote_balanced_sampler branch June 22, 2022 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JihwanEom JihwanEom JihwanEom approved these changes

@harimkang harimkang harimkang approved these changes

@chuneuny-emily chuneuny-emily chuneuny-emily left review comments

@goodsong81 goodsong81 Awaiting requested review from goodsong81

Assignees
No one assigned
Labels
ALGO Any changes in OTX Algo Tasks implementation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@supersoob @harimkang @chuneuny-emily @JihwanEom