make skip_tokens an input for VocabDecode (parametrize detokenization/decoding) #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaniukov
approved these changes
Nov 22, 2024
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 26, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 26, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 26, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 26, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
github-merge-queue bot
pushed a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 26, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
andrei-kochin
added a commit
to openvinotoolkit/openvino.genai
that referenced
this pull request
Nov 27, 2024
 Tokenizers IRs should be converted after openvinotoolkit/openvino_tokenizers#325 is merged Ticket CVS-154151
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to skip/unskip special tokens at runtime need to specify them as inputs, this PR does that for VocabDecoder.
PR for genai which uses this input openvinotoolkit/openvino.genai#1246
Ticket CVS-154151