Turn on UTF8Validate.REPLACE by default #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaniukov
approved these changes
Nov 20, 2024
|
there is still a typo, please don't merge. I will update when all typos are fixed |
|
fixed and checked. Both cli and python api correctly works by default and when 'ignore', 'replace', 'disable' are specified. |
ilya-lavrenov
approved these changes
Nov 20, 2024
pavel-esir
force-pushed
the
utf8_validate_by_default
branch
from
2522452 to
4fade27
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for
TextCallbackStreamerto handle unfinished characters correctlyhttps://github.com/openvinotoolkit/openvino.genai/blob/master/src/cpp/src/text_callback_streamer.cpp#L26-L27
CVS-157110