[Tokenizers][TF FE] Fix MUSE conversion #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
category: custom operations
|
build_jenkins |
rkazants
reviewed
Jan 31, 2024
rkazants
reviewed
Feb 1, 2024
modules/custom_operations/user_ie_extensions/tokenizer/sentence_piece.cpp
Outdated
Show resolved
Hide resolved
rkazants
approved these changes
Feb 1, 2024
rkazants
reviewed
Feb 1, 2024
Comment on lines
183
to
184
| // } | ||
| // set_node_name(node.get_name(), reshape); // TODO: requires dependencies from TF FE internals |
There was a problem hiding this comment.
do we need this? Please clean the code a bit.
rkazants
reviewed
Feb 1, 2024
Comment on lines
200
to
184
| if(auto pack = dynamic_cast<StringTensorPack*>(tensor.get_node())) { | ||
| // TODO: If it is a beginning of the graph, how to detect strings? It falls in 'else' branch in this case. | ||
| // FIXME: Needs extension for a Parameter to prepare it first | ||
| auto begins = std::make_shared<Reshape>(pack->input_value(0), shape, false); | ||
| auto ends = std::make_shared<Reshape>(pack->input_value(1), shape, false); | ||
| auto chars = pack->input_value(2); | ||
| auto reshape = post_translate_string_tensor_output({begins, ends, chars}); | ||
| return {reshape}; | ||
| } else { | ||
| auto reshape = std::make_shared<Reshape>(tensor, shape, false); | ||
| return {reshape}; | ||
| } | ||
| auto reshape = std::make_shared<Reshape>(tensor, shape, false); | ||
| return {reshape}; | ||
| // } | ||
| // set_node_name(node.get_name(), reshape); // TODO: requires dependencies from TF FE internals |
There was a problem hiding this comment.
I think you should revert these changes, they does not relate MUSE model
rkazants
approved these changes
Feb 1, 2024
|
@dtrawins @slyalin sentencepiece operation translated from TF with string input by default. It also allows input of a decomposed string representation, but this must be changed manually after the model is converted. This PR allows you to experiment with data format optimizations without having to recompile the extension. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.