More fixes of plugins.xml generation #9942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openvino-pushbot
added
the
category: inference
1) Unregistration is done by name (e.g. CPU), not by file name (ov_cpu_plugin) 2) Unregistered line is searched by name="MULTI" instead of just 'MULTI' to not conflict with MULTI_WORK_MODE_AS_AUTO entry 3) Removed list of all possible plugins from ov_runtime as logic shall not rely on this (not possible to add 3rd party plugins)
…ins are not built Registration - if some entry already exists in XML - don't copy it. E.g. - Registration of 'TEMPLATE' is performed - Registration loops through existing plugins.xml - If name="TEMPLATE" is found - don't take it to newContent - If name like "myCustomPlugin" is found - take it - As result - "myCustomPlugin" will exist after update, but old "TEMPLATE" will be removed
alpkn
approved these changes
Jan 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
name="MULTI"instead of justMULTIto not conflict with MULTI_WORK_MODE_AS_AUTO xml entryTickets: