[MO] Move reverse input channels before mean/scale #9182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusztabaka
requested review from
a team,
andrew-zaytsev and
nosovmik
and removed request for
a team
openvino-pushbot
added
category: MO
nosovmik
reviewed
Dec 13, 2021
nosovmik
approved these changes
Dec 13, 2021
mvafin
approved these changes
Dec 14, 2021
rkazants
reviewed
Dec 14, 2021
| @@ -59,11 +59,14 @@ Framework-agnostic parameters: | |||
| --reverse_input_channels | |||
| Switch the input channels order from RGB to BGR (or | |||
| vice versa). Applied to original inputs of the model | |||
There was a problem hiding this comment.
@nosovmik, why do we decide to stay "Applied to original inputs of the model..." instead of "Applied to user's input data..."?
There was a problem hiding this comment.
It is a legacy behavior, and it is consistent with model's documentation. E.g. if model is RGB and states that means (120, 130, 140) shall be applied, but user has BGR input - in this case user will need to --mean_values(120,130,140) --reverse_input_channels instead of converting something in the mind and have --mean_values(140,130,120) --reverse_input_channels
There was a problem hiding this comment.
Let us merge it and continue this discussion offline
rkazants
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.