TensorFlow FrontEnd Refactoring #9173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itikhono
changed the title
…ow_fe/refactoring
…ow_fe/refactoring
…ow_fe/refactoring
…ow_fe/refactoring
…ow_fe/refactoring
itikhono
requested review from
a team,
nosovmik,
ilyachur,
ilya-lavrenov and
rkazants
nosovmik
approved these changes
Dec 21, 2021
ilya-lavrenov
approved these changes
Dec 21, 2021
| /// Abstract representation for an input model graph that gives nodes in topologically sorted order | ||
| class TF_API GraphIterator : ov::RuntimeAttribute { | ||
| class TENSORFLOW_API GraphIterator : ov::RuntimeAttribute { |
There was a problem hiding this comment.
will not this macro conflict with actual TF macro?
Would be better to have name like OV_TENSORFLOW_API to denote it's OV specific
There was a problem hiding this comment.
But maybe we just need to remove a lot of macro per library and use generic OPENVINO_API
There was a problem hiding this comment.
will not this macro conflict with actual TF macro?
what do you mean? I renamed TF macro to TENSORFLOW macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
ov::frontend -> ov::frontend::tensorflow
"tensorflow_frontend" -> "openvino/frontends/tensorflow"
FrontEndTF -> tensorflow::FrontEnd (same for Model and Places)
Tickets: