[IE TEST] LRN tests fixed params #743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhail-treskin
suggested changes
Jun 5, 2020
|
|
||
| auto ngPrc = FuncTestUtils::PrecisionUtils::convertIE2nGraphPrc(netPrecision); | ||
| auto params = ngraph::builder::makeParams(ngPrc, {inputShapes}); | ||
| auto paramIn = | ||
| ngraph::helpers::convert2OutputVector(ngraph::helpers::castOps2Nodes<ngraph::op::Parameter>(params)); | ||
|
|
||
| auto lrn = std::make_shared<ngraph::opset1::LRN>(paramIn[0], alpha, beta, bias, size); | ||
| std::vector<int64_t> axes; | ||
| if (region == "same") { |
There was a problem hiding this comment.
I propose to parameterize the test directly with the axes parameter instead of some key-word which defines certain behavior of the test.
There are two advantages to such an approach. First of all, it is to be aligned with opset specification which describes LRN parameters and inputs. And also to make it possible to validate cases different from currently possible axes values {1} and {2,3,4,...}
l-bat
force-pushed
the
lbat/fix_lrn_ie_tests
branch
2 times, most recently
from
d14045b to
204ec85
Compare
|
please, take a look @mikhail-treskin |
iefode
reviewed
Jun 22, 2020
inference-engine/tests/functional/plugin/shared/src/single_layer_tests/lrn.cpp
Outdated
Show resolved
Hide resolved
l-bat
force-pushed
the
lbat/fix_lrn_ie_tests
branch
from
e7b54e5 to
7dd0faf
Compare
iefode
approved these changes
Jun 23, 2020
|
LGTM |
|
@mikhail-treskin Please review changes again |
mikhail-treskin
approved these changes
Jun 30, 2020
l-bat
force-pushed
the
lbat/fix_lrn_ie_tests
branch
from
7dd0faf to
e77d79e
Compare
l-bat
force-pushed
the
lbat/fix_lrn_ie_tests
branch
from
e77d79e to
7e9d07d
Compare
l-bat
force-pushed
the
lbat/fix_lrn_ie_tests
branch
from
7e9d07d to
91f0437
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now in LRN tests using
size_t beta, bias, butngraph::op::LRNtakesdouble beta, bias. We also need to add type of normalization channel algorithmOutput<Node> axes.please, take a look @iefode