-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[OV20 Preprocessing] Preprocessing API - basic preprocessing functionality #7391
Merged
ilyachur
merged 5 commits into
openvinotoolkit:master
from
nosovmik:ov20/preprocess_base
Sep 8, 2021
Merged
[OV20 Preprocessing] Preprocessing API - basic preprocessing functionality #7391
ilyachur
merged 5 commits into
openvinotoolkit:master
from
nosovmik:ov20/preprocess_base
Sep 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes API definition for trivial mean/scale operations (which don't require layout) Mean/scale with 'layout' support will be done under separate task together with Layout Current test code coverage: 100%
ilyachur
reviewed
Sep 7, 2021
ngraph/core/include/openvino/core/pre_post_process/input_info.hpp
Outdated
Show resolved
Hide resolved
ngraph/core/include/openvino/core/preprocess/pre_post_process.hpp
Outdated
Show resolved
Hide resolved
ilya-lavrenov
approved these changes
Sep 7, 2021
ilyachur
approved these changes
Sep 8, 2021
/// \param function Existing function representing loaded model | ||
/// | ||
/// \return Function with added pre/post-processing operations | ||
std::shared_ptr<Function> build(const std::shared_ptr<Function>& function); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we create a copy of function or we are changing the original funciton?
I mean that if we return the pointer to function the user can be surprised if original function also was changed.
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
…ality (openvinotoolkit#7391) * Preprocessing API - base classes Includes API definition for trivial mean/scale operations (which don't require layout) Mean/scale with 'layout' support will be done under separate task together with Layout Current test code coverage: 100% * Rename 'pre_post_process' folder to 'preprocess', aligned with namespace Fix 32-bit tests * More cleanup * Review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
Tickets: