Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OV20 Preprocessing] Preprocessing API - basic preprocessing functionality #7391

Merged
merged 5 commits into from
Sep 8, 2021

Conversation

nosovmik
Copy link
Contributor

@nosovmik nosovmik commented Sep 6, 2021

Details:

  • Includes API definition for trivial mean/scale operations (which don't require layout) + convert element type
  • Mean/scale with 'layout' support will be done under separate task together with Layout
  • Current test code coverage: 100%

Tickets:

  • 62178 (partial), 63866, 63906 (partial), 63867 (partial), 63866 (partial)

@nosovmik nosovmik requested review from ilya-lavrenov, ilyachur and a team September 6, 2021 15:12
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Sep 6, 2021
Includes API definition for trivial mean/scale operations (which don't require layout)

Mean/scale with 'layout' support will be done under separate task together
 with Layout

Current test code coverage: 100%
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Sep 7, 2021
/// \param function Existing function representing loaded model
///
/// \return Function with added pre/post-processing operations
std::shared_ptr<Function> build(const std::shared_ptr<Function>& function);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we create a copy of function or we are changing the original funciton?
I mean that if we return the pointer to function the user can be surprised if original function also was changed.

@ilyachur ilyachur merged commit b99e1d0 into openvinotoolkit:master Sep 8, 2021
@ilyachur ilyachur deleted the ov20/preprocess_base branch September 8, 2021 12:19
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
…ality (openvinotoolkit#7391)

* Preprocessing API - base classes

Includes API definition for trivial mean/scale operations (which don't require layout)

Mean/scale with 'layout' support will be done under separate task together
 with Layout

Current test code coverage: 100%

* Rename 'pre_post_process' folder to 'preprocess', aligned with namespace
Fix 32-bit tests

* More cleanup

* Review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: Core OpenVINO Core (aka ngraph)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants