-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move TF OD API docs to code + several fixes for TF OD API models conversion #7377
Merged
lazarevevgeny
merged 23 commits into
openvinotoolkit:master
from
lazarevevgeny:tf_od_api_docs_in_code
Sep 8, 2021
Merged
Move TF OD API docs to code + several fixes for TF OD API models conversion #7377
lazarevevgeny
merged 23 commits into
openvinotoolkit:master
from
lazarevevgeny:tf_od_api_docs_in_code
Sep 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…API models pre-processing.
…nversion of the TD OD API models. Remove mean/scale if padding is used and mean/scale is applied before resize
…SigmoidReplacement transformation
…ROIPoolingSecondReplacement transformation
…olingReplacement transformation
…Replacement transformation
…onOutputReplacement transformation
…th incorrect test data for the PipelineConfig parser class
lazarevevgeny
changed the title
Tf od api docs in code
Move TF OD API docs to code + several fixes for TF OD API models conversion
Sep 6, 2021
…ion file for TF OD API models
lazarevevgeny
requested review from
a team,
andrew-zaytsev,
mvafin and
iimironov
and removed request for
a team
September 7, 2021 11:17
jane-intel
approved these changes
Sep 7, 2021
popovaan
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
reviewed
Sep 7, 2021
mvafin
approved these changes
Sep 7, 2021
rkazants
approved these changes
Sep 8, 2021
popovaan
approved these changes
Sep 8, 2021
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
…ersion (openvinotoolkit#7377) * Refactored code, updated comments and documentation related to TF OD API models pre-processing. * Improved MO messages related to pre-processor block removal during conversion of the TD OD API models. Remove mean/scale if padding is used and mean/scale is applied before resize * Updated TF OD API transformation and documentation for SSD models * Updated comments and documentation for the ObjectDetectionAPIMaskRCNNSigmoidReplacement transformation * Updated comments and documentation for the ObjectDetectionAPIMaskRCNNROIPoolingSecondReplacement transformation * Updated comments and documentation for the ObjectDetectionAPIPSROIPoolingReplacement transformation * Updated comments and documentation for the ObjectDetectionAPIProposalReplacement transformation * Updated comments and documentation for the ObjectDetectionAPIDetectionOutputReplacement transformation * Minor code style fixes * Fixed unit tests for ObjectDetectionAPIPreprocessor2Replacement transformation * Improved unit test for pipeline.config parser. Fixed very long bug with incorrect test data for the PipelineConfig parser class * Code style fixes * Get rid of "coordinates_swap_method" parameter in the JSON configuration file for TF OD API models * Code style fixes and minor refactoring * Simplied code related to swapping Proposal coordinates * Removed incorrectly removed code * Fixed code review comments about the code comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause analysis: The documentation and code comments related to the conversion of the TF OD API models is not up to date.
Solution:
infer
function of the DetectionOutput operation in theObjectDetectionAPISSDPostprocessorReplacement
. Implemented the same functionality with a sub-graph of nodes.Ticket: 51541, 24709
Additional e2e validation performed:
Code:
Validation:
Documentation:
TODO: