Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GNA] Fixed scale factors propagation for Eltwise with very different inputs ranges #7305

Merged
merged 7 commits into from
Sep 8, 2021
Merged

[GNA] Fixed scale factors propagation for Eltwise with very different inputs ranges #7305

merged 7 commits into from
Sep 8, 2021

Conversation

elilobanova
Copy link
Contributor

@elilobanova elilobanova commented Aug 31, 2021 •
edited
Loading

Details:

  • Fixed scale factors propagation for Eltwise with very different inputs ranges
  • Exception is thrown in the case of not positive scale factor
  • Tests are added

Tickets:

63395

@elilobanova elilobanova requested review from a team August 31, 2021 13:28
@openvino-pushbot openvino-pushbot added category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common labels Aug 31, 2021
@elilobanova elilobanova changed the title [GNA] Fixed quantization for Eltwise and ScaleShift layers [GNA] Fixed scale factors propagation for Eltwise with very different inputs ranges Sep 1, 2021
@elilobanova elilobanova force-pushed the fix_eltwise_sf branch 2 times, most recently from c53602f to b1f87d6 Compare September 3, 2021 09:20
@dorloff dorloff merged commit 66a14f1 into openvinotoolkit:master Sep 8, 2021
elilobanova added a commit to elilobanova/openvino that referenced this pull request Sep 9, 2021
@elilobanova
[GNA] Fixed scale factors propagation for Eltwise with very different…
8844ccc 
… inputs ranges (openvinotoolkit#7305)

* [GNA] Fix scale factors propogation for Eltwise with very different inputs ranges

* [GNA] Added test

* [GNA] Added exception for scale factor <= 0

* [GNA] Disable tests with integer weights

* [GNA] Added assert for CNNLayer in getScaleFactor()

* [GNA] Added check if scale factor is inf

* [GNA] Fixed legacy tests
elilobanova added a commit to elilobanova/openvino that referenced this pull request Sep 10, 2021
@elilobanova
[GNA] Fixed scale factors propagation for Eltwise with very different…
d0d997a 
… inputs ranges (openvinotoolkit#7305)

* [GNA] Fix scale factors propogation for Eltwise with very different inputs ranges

* [GNA] Added test

* [GNA] Added exception for scale factor <= 0

* [GNA] Disable tests with integer weights

* [GNA] Added assert for CNNLayer in getScaleFactor()

* [GNA] Added check if scale factor is inf

* [GNA] Fixed legacy tests
dorloff pushed a commit that referenced this pull request Sep 13, 2021
@elilobanova
[GNA] Fixed scale factors propagation for Eltwise with very different…
b13bcbc 
… inputs ranges (#7305) (#7445)

* [GNA] Fix scale factors propogation for Eltwise with very different inputs ranges

* [GNA] Added test

* [GNA] Added exception for scale factor <= 0

* [GNA] Disable tests with integer weights

* [GNA] Added assert for CNNLayer in getScaleFactor()

* [GNA] Added check if scale factor is inf

* [GNA] Fixed legacy tests
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@elilobanova @akuporos
[GNA] Fixed scale factors propagation for Eltwise with very different…
d2adc97 
… inputs ranges (openvinotoolkit#7305)

* [GNA] Fix scale factors propogation for Eltwise with very different inputs ranges

* [GNA] Added test

* [GNA] Added exception for scale factor <= 0

* [GNA] Disable tests with integer weights

* [GNA] Added assert for CNNLayer in getScaleFactor()

* [GNA] Added check if scale factor is inf

* [GNA] Fixed legacy tests
tadamowicz pushed a commit to tadamowicz/openvino that referenced this pull request Aug 30, 2023
@elilobanova @dood-apo
[GNA] Fixed scale factors propagation for Eltwise with very different…
55fdc12 
… inputs ranges (openvinotoolkit#7305)

* [GNA] Fix scale factors propogation for Eltwise with very different inputs ranges

* [GNA] Added test

* [GNA] Added exception for scale factor <= 0

* [GNA] Disable tests with integer weights

* [GNA] Added assert for CNNLayer in getScaleFactor()

* [GNA] Added check if scale factor is inf

* [GNA] Fixed legacy tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitriikhurtin dmitriikhurtin dmitriikhurtin approved these changes

@sirzabek sirzabek sirzabek approved these changes

@nkogteva nkogteva nkogteva approved these changes

@mryzhov mryzhov Awaiting requested review from mryzhov

Assignees
No one assigned
Labels
category: GNA OpenVINO GNA plugin category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@elilobanova @nkogteva @sirzabek @dmitriikhurtin @openvino-pushbot @dorloff