Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Frontend][Paddle]Handle Exception in Op Conversion. #7296

Merged
merged 7 commits into from
Sep 13, 2021
Merged

[Frontend][Paddle]Handle Exception in Op Conversion. #7296

merged 7 commits into from
Sep 13, 2021

Conversation

zhangYiIntel
Copy link
Contributor

Details:

  • Handle Exception in Op Conversion
  • Check Paddle Model Version when converting

Tickets:

  • 61122

@zhangYiIntel zhangYiIntel requested review from ilyachur, mvafin, nosovmik and a team August 31, 2021 07:43
@zhangYiIntel zhangYiIntel marked this pull request as draft August 31, 2021 07:47
@openvino-pushbot openvino-pushbot added the category: Core OpenVINO Core (aka ngraph) label Aug 31, 2021
@zhangYiIntel zhangYiIntel marked this pull request as ready for review September 1, 2021 06:00
@zhangYiIntel zhangYiIntel requested a review from a team September 2, 2021 01:33
@zhangYiIntel
Copy link
Contributor Author

@nosovmik @ilyachur Could you help review ?

nosovmik
nosovmik approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@nosovmik nosovmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few very minor comments

ngraph/frontend/paddlepaddle/src/model.cpp Outdated Show resolved Hide resolved
ngraph/test/frontend/paddlepaddle/throw_in_conversion.cpp Outdated Show resolved Hide resolved
@zhangYiIntel zhangYiIntel added the category: PDPD FE OpenVINO PaddlePaddle FrontEnd label Sep 8, 2021
@zhangYiIntel zhangYiIntel added this to the 2022.1 milestone Sep 8, 2021
@zhangYiIntel
Copy link
Contributor Author

@ilyachur Could you have a review and merge the PR ?

@ilyachur ilyachur enabled auto-merge (squash) September 13, 2021 04:01
@ilyachur ilyachur merged commit f1f7376 into openvinotoolkit:master Sep 13, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@zhangYiIntel @akuporos
[Frontend][Paddle]Handle Exception in Op Conversion. (openvinotoolkit…
d829fe4 
…#7296)

* [Frontend][Paddle]Handle Exception in Op Conversion.

* [Frontend][Paddle]revise comments

* [Frontend][Paddle]add tests for error handling

* [Frontend]fix typo

* [Frontend][Paddle]relax model version check to 2.0.0

* [Frontend][Paddle]fix typo
@zhangYiIntel zhangYiIntel deleted the yi3/convert_check branch July 25, 2024 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nosovmik nosovmik nosovmik approved these changes

@ilyachur ilyachur ilyachur approved these changes

@mvafin mvafin Awaiting requested review from mvafin

Assignees
No one assigned
Labels
category: Core OpenVINO Core (aka ngraph) category: PDPD FE OpenVINO PaddlePaddle FrontEnd
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@zhangYiIntel @ilyachur @nosovmik @openvino-pushbot