Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created openvino plugin c++ wrapper #7259

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Created openvino plugin c++ wrapper #7259

merged 1 commit into from
Sep 13, 2021

Conversation

apankratovantonp
Copy link
Contributor

@apankratovantonp apankratovantonp commented Aug 26, 2021 •
edited
Loading

@apankratovantonp apankratovantonp requested review from ilya-lavrenov, ilyachur and a team August 26, 2021 13:53
@openvino-pushbot openvino-pushbot added category: inference OpenVINO Runtime library - Inference category: IE Tests OpenVINO Test: plugins and common labels Aug 26, 2021
@apankratovantonp apankratovantonp force-pushed the apa/ov_plugin branch 10 times, most recently from 833137a to a4f5e6b Compare August 31, 2021 09:24
@apankratovantonp apankratovantonp mentioned this pull request Sep 1, 2021
Merged
@apankratovantonp apankratovantonp requested a review from a team September 1, 2021 20:33
@apankratovantonp apankratovantonp force-pushed the apa/ov_plugin branch 2 times, most recently from d8cba94 to e9f9731 Compare September 10, 2021 06:55
@ilya-lavrenov
Copy link
Contributor

@apankratovantonp could you please fix merge conflicts?

@apankratovantonp apankratovantonp force-pushed the apa/ov_plugin branch 3 times, most recently from b8be99f to 6e65b8f Compare September 11, 2021 18:58
ilya-lavrenov
ilya-lavrenov approved these changes Sep 13, 2021
View reviewed changes
inference-engine/src/inference_engine/include/ie/details/ie_so_loader.h
@@ -55,6 +60,12 @@ class INFERENCE_ENGINE_API_CLASS(SharedObjectLoader) {
* @throws Exception if the function is not found
*/
void* get_symbol(const char* symbolName) const;

/**
* @brief Retruns reference to type erased implementation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-> Returns

inference-engine/tests/functional/plugin/shared/include/behavior/ov_core_integration.hpp
ASSERT_NO_THROW(executableNetwork.CreateInferRequest());
}

TEST_P(OVClassImportExportTestP, smoke_ExportUsingFileNameImportFromStreamNoThrowWithDeviceName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have we removed this test?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ExecutableNetwork::Export(const std::string&); was removed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but we can modify the tests with ExecutableNetwork::Export(std::ostream&); ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smoke_ImportNetworkNoThrowWithDeviceName does the same but just uses an in-memory byte stream instead of a file.

inference-engine/src/inference_engine/src/ie_core.cpp
}
}

class CoreImpl : public InferenceEngine::ICore, public std::enable_shared_from_this<InferenceEngine::ICore> {
mutable std::map<std::string, InferenceEngine::InferencePlugin> plugins;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove InferenceEngine::InferencePlugin?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to solve exceptions from DLL safety manually in each place where the IInferencePlugin API is used. It is very error-prone. With InferencePlugin we just keep all these wappers in a single place.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have ov::InferencePlugin and Ie::InferencePlugin. can we remove the last one?

@ilya-lavrenov ilya-lavrenov merged commit 2793963 into openvinotoolkit:master Sep 13, 2021
@ilya-lavrenov ilya-lavrenov added this to the 2022.1 milestone Sep 13, 2021
@ilya-lavrenov ilya-lavrenov self-assigned this Sep 13, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@apankratovantonp @akuporos
added openvino runtime plugin (openvinotoolkit#7259)
c833817
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-lavrenov ilya-lavrenov ilya-lavrenov approved these changes

@ilyachur ilyachur ilyachur approved these changes

Assignees

@ilya-lavrenov ilya-lavrenov

Labels
category: IE Tests OpenVINO Test: plugins and common category: inference OpenVINO Runtime library - Inference
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@apankratovantonp @ilya-lavrenov @ilyachur @openvino-pushbot