-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propose new Slice-8 operation - update #7257
Merged
andrei-kochin
merged 18 commits into
openvinotoolkit:master
from
mitruska:mitruska/slice8_spec
Sep 6, 2021
Merged
Propose new Slice-8 operation - update #7257
andrei-kochin
merged 18 commits into
openvinotoolkit:master
from
mitruska:mitruska/slice8_spec
Sep 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit a44ed32)
mitruska
requested review from
andrew-zaytsev,
avladimi and
tsavina
and removed request for
a team
August 26, 2021 13:02
mitruska
requested review from
lazarevevgeny,
postrational,
a team,
mbencer and
jane-intel
August 27, 2021 07:54
tsavina
reviewed
Aug 27, 2021
rkazants
reviewed
Aug 31, 2021
rkazants
reviewed
Aug 31, 2021
lazarevevgeny
approved these changes
Sep 1, 2021
rkazants
reviewed
Sep 1, 2021
rkazants
reviewed
Sep 1, 2021
rkazants
approved these changes
Sep 1, 2021
tsavina
approved these changes
Sep 2, 2021
postrational
reviewed
Sep 2, 2021
postrational
approved these changes
Sep 2, 2021
nshchego
approved these changes
Sep 3, 2021
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 6, 2021
* Propose new Slice-8 operation (cherry picked from commit a44ed32) * Align category * Update detailed descripiton * Update Inputs/Outputs description * Add no attributes info * Precise range of axis values * Update descriptions * More details about negative steps and slicing backwards * Add more details * Add examples * Change step input to Required * Apply spell check comments * Add missing commas * Add separate T_AXIS type for axis input * Make example data 2D * Remove duplicated example * Apply review suggestions Co-authored-by: Michal Karzynski <[email protected]>
akuporos
pushed a commit
to akuporos/openvino
that referenced
this pull request
Sep 29, 2021
* Propose new Slice-8 operation (cherry picked from commit a44ed32) * Align category * Update detailed descripiton * Update Inputs/Outputs description * Add no attributes info * Precise range of axis values * Update descriptions * More details about negative steps and slicing backwards * Add more details * Add examples * Change step input to Required * Apply spell check comments * Add missing commas * Add separate T_AXIS type for axis input * Make example data 2D * Remove duplicated example * Apply review suggestions Co-authored-by: Michal Karzynski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details:
new Slice-8 operation specification
Based on the previous draft (#5393) this PR is updated ready for review Slice-8 specification.
Tickets: