Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPU] Disable NotImpelmented exceptions mechanism for generic node. #7242

Merged
merged 2 commits into from
Sep 13, 2021
Merged

[CPU] Disable NotImpelmented exceptions mechanism for generic node. #7242

merged 2 commits into from
Sep 13, 2021

Conversation

IvanNovoselov
Copy link
Contributor

@IvanNovoselov IvanNovoselov commented Aug 25, 2021 •
edited
Loading

Details:

  • The mechanism of NotImplemented exceptions in MKLDNN NodesFactory is deprecated and should be removed to prevent probable linking issues

Tickets:

  • 61707

@IvanNovoselov IvanNovoselov requested review from a team August 25, 2021 13:13
@openvino-pushbot openvino-pushbot added the category: CPU OpenVINO CPU plugin label Aug 25, 2021
@IvanNovoselov IvanNovoselov removed request for a team August 25, 2021 16:04
@IvanNovoselov IvanNovoselov force-pushed the remove_genericNode_exceptions branch from 82fa078 to 7759570 Compare August 26, 2021 08:27
@dmitry-gorokhov
Copy link
Contributor

@EgorDuplensky please review the PR. After this change we shouldn't face multiple exceptions during debag.

@dmitry-gorokhov dmitry-gorokhov added this to the 2022.1 milestone Aug 30, 2021
@IvanNovoselov IvanNovoselov requested a review from a team August 30, 2021 09:20
@IvanNovoselov IvanNovoselov force-pushed the remove_genericNode_exceptions branch 2 times, most recently from 462fbc3 to 6b049e5 Compare September 8, 2021 08:45
@IvanNovoselov
Copy link
Contributor Author

@dmitry-gorokhov could you please take a look?

@IvanNovoselov IvanNovoselov force-pushed the remove_genericNode_exceptions branch from 6b049e5 to c6d6203 Compare September 9, 2021 12:32
@IvanNovoselov IvanNovoselov force-pushed the remove_genericNode_exceptions branch from c6d6203 to daf0da5 Compare September 10, 2021 13:24
@dmitry-gorokhov dmitry-gorokhov merged commit cb0d6db into openvinotoolkit:master Sep 13, 2021
@IvanNovoselov IvanNovoselov deleted the remove_genericNode_exceptions branch September 15, 2021 15:00
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@IvanNovoselov @akuporos
[CPU] Disable NotImpelmented exceptions mechanism for generic node. (o…
df5f37b 
…penvinotoolkit#7242)
IvanNovoselov added a commit to IvanNovoselov/openvino that referenced this pull request Nov 16, 2021
@IvanNovoselov
[CPU] Disable NotImpelmented exceptions mechanism for generic node. (o…
11cafbc 
…penvinotoolkit#7242)
IvanNovoselov added a commit to IvanNovoselov/openvino that referenced this pull request Nov 16, 2021
@IvanNovoselov
[CPU] Disable NotImpelmented exceptions mechanism for generic node. (o…
eff64d3 
…penvinotoolkit#7242)
IvanNovoselov added a commit to IvanNovoselov/openvino that referenced this pull request Dec 20, 2021
@IvanNovoselov
[CPU] Disable NotImpelmented exceptions mechanism for generic node. (o…
557ccdd 
…penvinotoolkit#7242)

 (cherry picked from commit cb0d6db)
dmitry-gorokhov pushed a commit that referenced this pull request Dec 27, 2021
@IvanNovoselov
[CPU] Disable NotImpelmented exceptions mechanism for generic node. (#…
e212424 
…7242) (#9346)

(cherry picked from commit cb0d6db)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EgorDuplensky EgorDuplensky EgorDuplensky approved these changes

@dmitry-gorokhov dmitry-gorokhov dmitry-gorokhov approved these changes

Assignees

@dmitry-gorokhov dmitry-gorokhov

Labels
category: CPU OpenVINO CPU plugin
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
4 participants
@IvanNovoselov @dmitry-gorokhov @EgorDuplensky @openvino-pushbot