Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attri… #7214

Merged
merged 3 commits into from
Sep 7, 2021
Merged

[FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attri… #7214

merged 3 commits into from
Sep 7, 2021

Conversation

ceciliapeng2011
Copy link
Contributor 

[FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attribute str_value be empty.

This happens when export ppyolo with PaddleDetection release/2.2.

@ceciliapeng2011 ceciliapeng2011 requested a review from a team August 24, 2021 02:42
@ceciliapeng2011
Copy link
Contributor Author

ceciliapeng2011 commented Aug 24, 2021 •
edited
Loading

@liubo-intel @zhangYiIntel @ilyachur @mvafin this is a fix. please help review.

test case used -
https://github.com/ceciliapeng2011/openvino-paddlepaddle-demo/blob/main/model-test/yolo_infer.py

ilyachur
ilyachur reviewed Aug 24, 2021
View reviewed changes
Copy link
Contributor

@ilyachur ilyachur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I right that these changes already covered by tests?

@ilyachur ilyachur added this to the 2022.1 milestone Aug 24, 2021
@ceciliapeng2011
Copy link
Contributor Author

@ilyachur yes, it is tested.

@ceciliapeng2011 ceciliapeng2011 force-pushed the cecilia/fix/fill_constant_batch_size_like branch from 811db86 to 75445d3 Compare August 30, 2021 05:25
@ceciliapeng2011
[FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attri…
dda4fee 
…bute str_value be empty.

This happens when export ppyolo with PaddleDetection release/2.2.
@ceciliapeng2011
code refactor.
75445d3
@ilyachur ilyachur added the category: PDPD FE OpenVINO PaddlePaddle FrontEnd label Aug 31, 2021
@ilyachur ilyachur merged commit 8eeee5e into openvinotoolkit:master Sep 7, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@ceciliapeng2011 @akuporos
[FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attri… (
d938692 
openvinotoolkit#7214)

* [FrontEnd][PaddlePaddle] fix fill_constant_batch_size_like when attribute str_value be empty.

This happens when export ppyolo with PaddleDetection release/2.2.

* code refactor.

* remove uncertain comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhangYiIntel zhangYiIntel zhangYiIntel approved these changes

@ilyachur ilyachur ilyachur approved these changes

@mvafin mvafin Awaiting requested review from mvafin

@liubo-intel liubo-intel Awaiting requested review from liubo-intel

@nosovmik nosovmik Awaiting requested review from nosovmik

@jane-intel jane-intel Awaiting requested review from jane-intel

Assignees
No one assigned
Labels
category: PDPD FE OpenVINO PaddlePaddle FrontEnd
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ceciliapeng2011 @ilyachur @zhangYiIntel