Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise NotEqual #7198

Merged
merged 35 commits into from
Sep 8, 2021
Merged

Revise NotEqual #7198

merged 35 commits into from
Sep 8, 2021

Conversation

nsemaev
Copy link
Contributor

@nsemaev nsemaev commented Aug 23, 2021 •
edited
Loading

Details:

  • Added template plugin tests
  • Absent the instances of NotEqual tests in the backend ngraph
  • There is no unnecessary duplication of reference implementation
  • All backend tests are removed
  • nGraph operator class was reviewed
  • Reference implementation was revised

Tickets:

  • 37459, 45999, 46001

@nsemaev nsemaev requested a review from a team as a code owner August 23, 2021 10:59
@nsemaev nsemaev requested review from a team, andrew-zaytsev, avladimi and tsavina and removed request for a team August 23, 2021 10:59
@openvino-pushbot openvino-pushbot added the category: IE Tests OpenVINO Test: plugins and common label Aug 23, 2021
@andrei-kochin andrei-kochin requested a review from iefode August 25, 2021 11:16
@nsemaev nsemaev requested a review from a team August 27, 2021 10:17
@nsemaev nsemaev requested a review from a team September 2, 2021 09:40
@ilyachur ilyachur added this to the 2022.1 milestone Sep 3, 2021
mitruska
mitruska approved these changes Sep 3, 2021
View reviewed changes
Copy link
Contributor

@mitruska mitruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add this op to verified ops list:
/inference-engine/tests/ie_test_utils/functional_test_utils/layer_tests_summary/utils/constants.py

@bszmelcz As you revised Equal operation, could you take a look at this PR?

@mitruska mitruska requested a review from bszmelcz September 3, 2021 10:17
@nsemaev
Copy link
Contributor Author

nsemaev commented Sep 3, 2021

Please add this op to verified ops list:
/inference-engine/tests/ie_test_utils/functional_test_utils/layer_tests_summary/utils/constants.py

@bszmelcz As you revised Equal operation, could you take a look at this PR?

This file does not seem to exist in the official OpenVINO repository anymore
https://github.com/openvinotoolkit/openvino/blob/master/inference-engine/tests/ie_test_utils/functional_test_utils/layer_tests_summary/utils/constants.py

@mitruska
Copy link
Contributor

mitruska commented Sep 3, 2021

This file does not seem to exist in the official OpenVINO repository anymore
https://github.com/openvinotoolkit/openvino/blob/master/inference-engine/tests/ie_test_utils/functional_test_utils/layer_tests_summary/utils/constants.py

Oh I see, the list was removed yesterday #7285.
So no longer relevant (FYI @iefode)

@iefode
Copy link
Contributor

iefode commented Sep 7, 2021

@nsemaev Please resolve the conflicts. After that I will merge the changes

@iefode iefode merged commit 3c22b2a into openvinotoolkit:master Sep 8, 2021
akuporos pushed a commit to akuporos/openvino that referenced this pull request Sep 29, 2021
@nsemaev @akuporos
Revise NotEqual (openvinotoolkit#7198)
79a0350 
* Hiding the problem, Validate() changes 'function'

* Template plugin tests

* Undo the changes that are not necessary

* Align code style

* Added \n at end of file

* Removing an unused implementation

* New version with Code Style checking

* Cleaning backend tests

* Reworked the tests the right way

* Removed visit_attributes()

* Removed visit_attributes() in source file

* Added NGRAPH_CHECK macros to evaluate()

* Removed zero_sized_not_equal mention from unit_test.manifest

* Added function name to the constants.py

* Revert "Added function name to the constants.py"

This reverts commit 5b74780.

* Return visit_attributes() for op::v1::NotEqual due to NotEqual being moved to another location
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bszmelcz bszmelcz bszmelcz approved these changes

@mitruska mitruska mitruska approved these changes

@ilyachur ilyachur ilyachur approved these changes

@andrew-zaytsev andrew-zaytsev Awaiting requested review from andrew-zaytsev

@avladimi avladimi Awaiting requested review from avladimi

@tsavina tsavina Awaiting requested review from tsavina

@iefode iefode Awaiting requested review from iefode

@ggalieroc-zz ggalieroc-zz Awaiting requested review from ggalieroc-zz

Assignees
No one assigned
Labels
category: IE Tests OpenVINO Test: plugins and common
Projects
None yet
Milestone
2022.1
Development

Successfully merging this pull request may close these issues.
6 participants
@nsemaev @mitruska @iefode @ilyachur @bszmelcz @openvino-pushbot