Separate executable for paddlepaddle unit tests #6862
Conversation
nosovmik
force-pushed
the
pdpd_separate_tests
branch
from
b7774d5 to
bc47fc4
Compare
…older Also produce build time warning when paddle test models generation is disabled
# Conflicts: # ngraph/test/CMakeLists.txt
# Conflicts: # .ci/azure/linux.yml # .ci/azure/windows.yml # ngraph/test/CMakeLists.txt # ngraph/test/requirements_test.txt
| # ONNX - generate test models | ||
| docopt~=0.6.2 | ||
| onnx~=1.9.0 |
There was a problem hiding this comment.
I believe this can be removed at all since ONNX has its own file now https://github.com/openvinotoolkit/openvino/blob/master/ngraph/test/requirements_test_onnx.txt
| return rc; | ||
| } | ||
|
|
||
| std::string get_current_executable_path() |
There was a problem hiding this comment.
can we use https://github.com/openvinotoolkit/openvino/blob/master/inference-engine/tests/ie_test_utils/common_test_utils/file_utils.hpp#L243 from commonTestUtils? I see it's linked to shared FE tests
| target_include_directories(${TARGET_NAME} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/include) | ||
| target_include_directories(${TARGET_NAME} PUBLIC ${CMAKE_CURRENT_SOURCE_DIR}/../..) | ||
| target_link_libraries(${TARGET_NAME} PUBLIC frontend_manager | ||
| ngraph::ngraph cnpy ie_backend ngraph_test_util commonTestUtils) |
There was a problem hiding this comment.
I don't see that commonTestUtils is used.
But if we really need it, we can reuse https://github.com/openvinotoolkit/openvino/blob/master/inference-engine/tests/ie_test_utils/common_test_utils/file_utils.hpp#L243
There was a problem hiding this comment.
commonTestUtils dependency on tests was introduced before in PR #6784
Ok, I didn't know that file_utils now have 'getExecutablePath', will reuse it
|
|
||
| # Fuzzy tests for PaddlePaddle use IE_CPU engine | ||
| if (ENABLE_MKL_DNN) | ||
| add_dependencies(${TARGET_NAME} MKLDNNPlugin) |
There was a problem hiding this comment.
I'm against of having such dependency.
We want to remove dependency on IE from ngraph tests. Currently we have it because of historical reasons, but we want to remove ngraph backends and keep only IE plugins. So, ngraph tests will not depend on IE
# Conflicts: # .ci/azure/linux.yml # .ci/azure/windows.yml
# Conflicts: # .ci/azure/linux.yml
* Separate executable for paddlepaddle unit tests * Fix CI * Move PaddlePaddle-specific python requirements to paddlepaddle test folder Also produce build time warning when paddle test models generation is disabled * Renamed back PADDLE_TEST_MODELS_DIRNAME to TEST_PADDLE_MODELS_DIRNAME * Add dependency on CPU plugin (PaddlePaddle fuzzy tests use CPU plugin for inference) * Fix code style * Fix review comments #2 * Code style fix * Add dependency of 'paddlepaddle_test_models' to 'test_model_zoo'
* Separate executable for paddlepaddle unit tests * Fix CI * Move PaddlePaddle-specific python requirements to paddlepaddle test folder Also produce build time warning when paddle test models generation is disabled * Renamed back PADDLE_TEST_MODELS_DIRNAME to TEST_PADDLE_MODELS_DIRNAME * Add dependency on CPU plugin (PaddlePaddle fuzzy tests use CPU plugin for inference) * Fix code style * Fix review comments #2 * Code style fix * Add dependency of 'paddlepaddle_test_models' to 'test_model_zoo'
* Separate executable for paddlepaddle unit tests * Fix CI * Move PaddlePaddle-specific python requirements to paddlepaddle test folder Also produce build time warning when paddle test models generation is disabled * Renamed back PADDLE_TEST_MODELS_DIRNAME to TEST_PADDLE_MODELS_DIRNAME * Add dependency on CPU plugin (PaddlePaddle fuzzy tests use CPU plugin for inference) * Fix code style * Fix review comments #2 * Code style fix * Add dependency of 'paddlepaddle_test_models' to 'test_model_zoo'
Details:
Tickets: